maint: let a manual dispatch advance the pins - #2
Merged
Merged
Conversation
The workflow already offered workflow_dispatch, but the advance step was gated on the schedule alone, so a manual run tested the pins it already had and changed nothing. That leaves the suite testing against superseded revisions until the next Monday whenever the family lands a change worth testing against now. Run the advance on either trigger, and take the trigger's name for the commit message and the committer identity, which said "cron" regardless. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow already offers
workflow_dispatch, but the advance step is gated ongithub.event_name == 'schedule'alone. A manual run therefore tests the pins it already has and changes nothing, which is not what a manual trigger on a drift detector looks like it should do.That matters right now:
caissonandcaisson-coreboth landed changes today, and this repository's lock still points at revisions from before them (caissonatbfd018fagainst7f80a1eon main,caisson-coreat7ad0139against32a7fae). Without this, the suite tests the family against superseded revisions until Monday.What changed
The advance runs on either trigger. The commit message and the committer identity now take the trigger's name instead of saying "cron" and "scheduled" regardless of how the run started.
Verification
I ran the advance locally on
mainexactly as the step does.nix flake updatemoves four inputs (caisson,caisson-core,nixpkgs, andhome-manager), and against that advanced worldnix flake check -Lpasses and the suite reportsok: 22 tests passed. So the advance this enables is green before it is enabled.After merging, dispatching this workflow on
mainwill advance the lock and commit it.