maint: bump CI actions and keep CI on upstream Nix - #1
Merged
Merged
Conversation
The workflow pinned nix-installer-action@v16 (November 2024) and actions/checkout@v4; neither pin was deliberate. Move to v22 and v7. The installer has defaulted `determinate` to true since v21, which would have switched CI from upstream Nix to Determinate Nix as a side effect of the bump. Pass `determinate: false` so the checks keep running against the Nix a consumer of this flake is likely to have. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix-installer-actionwas pinned atv16(November 2024) andactions/checkoutatv4. Neither pin was deliberate:v16was already about eight months stale when it arrived in the first commit, and it was copied forward into every workflow in the family. This moves them tov22andv7.The one behavior change worth knowing about
Since
v21the installer defaultsdeterminateto true, so a plain version bump would have switched CI from upstream Nix to Determinate Nix as a side effect. This passesdeterminate: falseat each call site, with a comment saying why, so the checks keep running against the Nix a consumer of this flake is likely to have. Changing distributions is a decision worth making on purpose rather than inheriting from a bump.Checked, not assumed
Nothing in checkout
v5throughv7affects these workflows. The checkouts are plain, sov6's move of persisted credentials to a separate file andv7's block on checking out fork PRs underpull_request_target/workflow_rundo not apply.persist-credentialsstill defaults to true inv7, which matters forcaisson-compat, whose scheduled job commits and pushes an advancedflake.lock.The same change goes to all three repositories in the family (
caisson,caisson-core,caisson-compat), six call sites in total.