Skip to content

Added packing module.#3

Open
dwieker wants to merge 1 commit intonkeim:numbafrom
dwieker:numba
Open

Added packing module.#3
dwieker wants to merge 1 commit intonkeim:numbafrom
dwieker:numba

Conversation

@dwieker
Copy link
Copy Markdown

@dwieker dwieker commented Nov 7, 2015

2D pair correlation function with edge handling.

@danielballan
Copy link
Copy Markdown

Oh, excellent! I have been hoping to get this functionality in trackpy for a long time.

Would you consider putting this pull request against the upstream fork at https://github.com/soft-matter/trackpy where all the contributors can review it?

@danielballan
Copy link
Copy Markdown

P.S. @nkeim I had forgotten that I started watching your fork before we joined forces. :- )

@nkeim
Copy link
Copy Markdown
Owner

nkeim commented Nov 7, 2015

Hi @danielballan ! I'm actually advising @dwieker on his senior project, so our plan was to discuss the code here before it goes over to the main repo. But your comments are welcome here or anywhere!

@danielballan
Copy link
Copy Markdown

Wonderful. I thought I might be missing some offline conversation here, but I can't resist the opportunity to welcome new potential contributors. Welcome, @dwieker!

@nkeim
Copy link
Copy Markdown
Owner

nkeim commented Nov 7, 2015

@dwieker This PR should be targeting the "master" branch. (It's confusing because the "numba" branch is the default on my fork, for historical reasons.) But if that proves difficult I can still do some code review here.

nkeim pushed a commit that referenced this pull request Feb 20, 2016
nkeim pushed a commit that referenced this pull request Oct 3, 2016
TST: Fix sorting in tests for pandas 0.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants