Repository navigation
fix(callout): keep the unavailable-content notice's bottom margin - #355
Merged
Merged
Conversation
github-actions
Bot
added
package
Contributor
Docs previewThis pull request closed, so its preview is gone. |
Contributor
Visual changes2 of 604 renders changed at 20b0622, compared with the base branch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack keeps the 6px bottom margin of the "This content could not be displayed." notice when it is a callout's last child, so the callout's padding starts below it. The renderer kept it only for a callout inside a container; a callout on its own was 5–6px shorter than Slack's. The rule now applies to every callout.
Type of change
fix)feat)perf)!, e.g.feat(provider)!:): exported components, props, hooks or entry pointsdocs,chore,ci,build,refactor,test)Slack reference
catalog/callout/callout, compared locally against Block Kit Builder. All 15 callout fixtures move; the largest:calloutcallout@darkcallout@hidden+darkcallout@hidden+mobile+darkcallout@focus-menu-1+mobile+darkcatalog/container/with-calloutandextra/fidelity/contact-card/mixedstay at 0.00%.Checklist
apps/docs,docs/README.md,packages/block-kit/README.md,AGENTS.md)bun run lint,bun run format:check,bun run type-checkandbun run testpass locallytype(scope): subjectThe visual comparison is the test here: the change is one CSS rule, and jsdom doesn't lay out. No docs describe the spacing.