Skip to content

Fix validation logic for the chat history #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PabloReyes wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix validation logic for the chat history #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2f45de
Include "assistant" as a valid role for the conversation history
PabloReyes Oct 28, 2024
41c790c
Revert "Include "assistant" as a valid role for the conversation hist…
PabloReyes Oct 28, 2024
d35805c
Include "assistant" as a valid role for the conversation history
PabloReyes Oct 28, 2024
150dd2f
Fix typo with --api-key option. Should be --apiKey
PabloReyes Oct 29, 2024
7bd63da
Fix Role "assistant" not recognized in chat history
PabloReyes Oct 29, 2024
59adff8
Typos. "OpenAPI" should be "OpenAI"
PabloReyes Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/node/express/src/express/validators/chat/isValidConversationHistory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@ export const isValidConversationHistory = (history: any) => {
return true;
}

if (
(item.role !== 'user' && item.role !== 'ai' && item.role !== 'system') ||
typeof item.message !== 'string'
) {
if (!['user', 'ai', 'system', 'assistant'].includes(item.role) || typeof item.message !== 'string') {
return true;
}
})) {
Expand Down
6 changes: 3 additions & 3 deletions packages/node/server/src/serve/displayHelp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ export const displayHelp = () => {
log(' @nlbridge/server [params]');
log('');
log('Required:');
log(' --api <openapi> The AI backend to use\n' +
' Only OpenAPI is supported at the moment');
log(' --api <openai> The AI backend to use\n' +
' Only OpenAI is supported at the moment');
log('');
log('Optional:');
log(' --api-key <key> The API key to use for the AI backend\n' +
log(' --apiKey <key> The API key to use for the AI backend\n' +
' Default: Read from environment variable (e.g. OPENAI_API_KEY)\n');
log(' --port [port] Port to use for HTTP server - Default: Random value between 8000 and 8999');
log(' --cors <origin> Enable CORS for the specified origin - Default: "*"');
Expand Down
6 changes: 3 additions & 3 deletions pipeline/npm/server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ Usage:
@nlbridge/server [params]

Required:
--api <openapi> The AI backend to use
Only OpenAPI is supported at the moment
--api <openai> The AI backend to use
Only OpenAI is supported at the moment

Optional:
--api-key <key> The API key to use for the AI backend
--apiKey <key> The API key to use for the AI backend
Default: Read from environment variable (e.g. OPENAI_API_KEY)

--port [port] Port to use for HTTP server - Default: Random value between 8000 and 8999
Expand Down