Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates nlmixr2plot to optionally use the tidyvpc package as an alternative backend for VPC plotting, along with associated test adjustments and a patch version bump.
Changes:
- Added a
methodoption tovpcPlot()to select betweenvpcandtidyvpcbackends. - Updated tests around VPC plotting/censoring (including removing/commenting pred-correction expectations).
- Bumped package version to 5.0.1 and noted the change in
NEWS.md; movedvpcfrom Imports to Suggests and addedtidyvpcto Suggests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| R/vpcPlot.R | Introduces method selection and a tidyvpc-based implementation path for VPC plotting. |
| tests/testthat/test-plots.R | Adjusts VPC simulation setup and comments out pred-correction plot expectations. |
| tests/testthat/test-plots-cens.R | Updates dplyr usage (reframe) and removes a pred-correction-related expectation. |
| DESCRIPTION | Bumps version; moves vpc to Suggests and adds tidyvpc. |
| NEWS.md | Adds a 5.0.1 entry describing optional tidyvpc usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@mattfidler I've opened a new pull request, #47, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: mattfidler <514778+mattfidler@users.noreply.github.com>
docs: add `@param method` to `vpcPlot()` roxygen documentation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
NEWS.md:3
- NEWS entry says "Updated nlmixr2 to optionally use the
tidyvpcpackage", but this repository/package isnlmixr2plot. This looks like a copy/paste and could confuse readers of the changelog; consider correcting the package name referenced here.
# nlmixr2plot 5.0.1
* Updated nlmixr2 to optionally use the `tidyvpc` package
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.