Repository navigation
MCP sign-in: a refused client registration names its fix, and an ask card's failed start lands on Integrations - #76
Closed
erikcostlow wants to merge 1 commit into
Conversation
…card's failed start lands on Integrations When a service's registration endpoint refuses the dynamic client registration - the real case is Harness's Keycloak answering 403 insufficient_scope from its "DCR Trusted hosts" policy - the sign-in route already says registration_refused, but no UI message existed for that code, so the member saw the bare "The sign-in failed. Try again." and retrying could never help. signInErrorText now has its own message for it, in all four catalogs, pointing to the client ID from the service's documentation, in the server's settings on Integrations → MCP. The secret-request card's OAuth save started the sign-in with the failure swallowed, and the save closes the ask, so a refused start left the member with nothing at all - no page ever opened. A refused start now sends the browser to /integrations?mcpSignIn=<reason>, where the callback would have gone, with the usual note of whose server it was, so the server's row shows the reason and offers the sign-in again. The registration stub can answer a refusal with another status than 400 (dcrStatus), so the tests cover the 403 case end to end.
nmamano
pushed a commit
that referenced
this pull request
Nov 19, 2026
…card's failed start lands on Integrations (task f51a8f51, PR #76, closes #75) When a service's registration endpoint refuses the dynamic client registration (for example a Keycloak "DCR Trusted hosts" policy answering 403 insufficient_scope), the sign-in route already answered registration_refused, but the UI had no message for that code and showed the generic "try again". signInErrorText now has its own message in all four catalogs: the server refused to register a client, so enter a client ID from its documentation. The secret-request card's OAuth save started the sign-in and swallowed a failure, and the save closes the ask, so a refused start left the member with nothing. A refused start now sends the browser to /integrations?mcpSignIn=<reason>, with the usual note of whose server it was, so the server's row shows the reason and offers the sign-in again. The registration stub can answer a refusal with a status other than 400 (dcrStatus), so the tests cover the 403 case end to end. Tests also cover the ask card's refused reason and a network error. asks-design.md says where a failed ask-card start lands. Contributed by Erik Costlow in PR #76; review fixes and tests by the Isomux loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nmamano
added a commit
that referenced
this pull request
Nov 19, 2026
… in the words Nil approved (task d2080083, sign-off change for f51a8f51, PR #76) Shortens settings.mcpServers.signInError.registrationRefused in en, ca, es and zh. Copy only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for the fix and the clear write-up. It landed in main as one squash commit with your name on it (1e8e26e), so I am closing this PR. Our review added a case for a start that fails with no reason (a network error), which now also lands on Integrations, and shortened the new message to "This server refused to register a client. Enter a client ID." It ships in the next release. Written by an AI model (Claude), working for Nil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
When a service refuses the Dynamic Client Registration - the issue's real case is Harness's Keycloak answering 403 insufficient_scope - the sign-in route already answers 502 sign_in_failed with reason registration_refused, but signInErrorText had no case for it, so the member saw the bare "The sign-in failed. Try again.", which retrying can never fix. The secret ask card's OAuth save swallowed the failure entirely (.catch(() => {}), and the save closes the card), so there the member saw nothing at all - no page ever opened.
The change:
Checks, run on macOS - bun run ci runs only on Linux and was not run: