feat!: support enableBufferObjects and add requiredGeometryCapabilities - #293
Merged
Conversation
🤖 Generated with GitHub Actions
🤖 Generated with GitHub Actions
🤖 Generated with GitHub Actions
🤖 Generated with GitHub Actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Filament
VertexBufferuses either:VertexBuffer::setBufferAt, orVertexBuffer::Builder::enableBufferObjects()and attached withVertexBuffer::setBufferObjectAt, allowing streams to be shared or swapped without rebuilding the vertex buffer.The storage model is fixed when the vertex buffer is created, but Filament currently provides no API for querying it afterward.
This PR therefore exposes BufferObject and VertexBufferBuilder.enableBufferObjects() for low-level procedural geometry. Thermion records the storage model when a buffer is created or exposed through an asset, and reports it through VertexBuffer.storageMode.
This PR also replaces VertexBufferMode with geometry requirements. Callers describe the geometry properties they require rather than selecting a particular reconstruction strategy:
The available geometry capabilities are:
The loader resolves requirements as follows:
Flat shading is intentionally not a geometry capability. It is a rendering operation supported by the unwelded representation and can be queried independently through ThermionAsset.supportsFlatShading. .
The resulting public responsibilities are distinct: