-
Notifications
You must be signed in to change notification settings - Fork 4
Add comprehensive support for fertilizer application methods and metadata #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
2ff9ba4
feat: add value/label for p_app_method
SvenVw a58b367
feat: Add new function `getSoilParameterDescription` to obtain detail…
SvenVw 2fb2db3
feat: Improve design of the fertilizer form page by making it more in…
SvenVw 0e2fe59
feat: export types
SvenVw 4356a53
refactor: remove not used import
SvenVw c962751
feat: Replace p_type_** with p_type at all fertilizer functions
SvenVw 1505b4c
refactor: replace p_type usage at fdm-calculator
SvenVw fc75c27
fix: fix parameter description
SvenVw 17facb6
fix: description of options for p_type
SvenVw 072f778
feat: switch to select for p_type
SvenVw 0ba9291
feat: make p_app_method_options to multiselect
SvenVw 29723a3
feat: add checkboxes for application methods
SvenVw 349cee7
fix: improve description
SvenVw bc125a8
feat: add p_app_method_options to form submission
SvenVw 3bb59e0
feat: use new form for exisiting fertilizers as well
SvenVw e37b6f0
feat: add `p_app_method_options` as parameter of Fertilizer Catalogue
SvenVw 75693e4
feat: Add parameter `p_app_method_options` to `fertilizer_catalogue` …
SvenVw 7f95233
feat: make various types available
SvenVw 8ea36cb
feat: implement p_app_method_options in various fertilizer functions
SvenVw 5eb69f8
fix: type errors
SvenVw ef6a9d1
refactor: update test
SvenVw ac05d8b
fix: at `syncCatalogue` that when item already exists, but the hash h…
SvenVw 592732e
fix: set updated value
SvenVw d7219c1
feat: use 2 columns for application methods on large screens
SvenVw 2355d88
fix: validation of optional fields
SvenVw 0102095
feat: add validation that p_n_wc is required when p_n_rt is provided
SvenVw b8fc220
chore: style
SvenVw 4cc29dc
fix: form parsing for more complex types
SvenVw 5f9e9e0
feat: Add application method to form for fertilizer application
SvenVw 78ebd90
fix: store p_app_method
SvenVw 3f79b0e
feat: Show application method for each application in the list of fe…
SvenVw 36803f1
feat: Add feature to select an existing fertilizer as template for a…
SvenVw 68ff33b
fix: validation errors
SvenVw a41b0dc
refactor: remove not used conponent
SvenVw 2015d13
fix: typo
SvenVw 634bf26
fix: unit test
SvenVw 04a0c09
fix: add validation for selecting an option for p_app_method
SvenVw 517c467
fix: Reject empty values rather than just requiring one truthy element
SvenVw e9389f3
fix: prevent possbible runtime crash when option is missing
SvenVw ef50866
fix: type
SvenVw 6fb4f35
refactor: remove obsolete types
SvenVw eac4cd5
fix: validation for selecting at least 1 application method
SvenVw 27dec38
fix: type
SvenVw d1ea37e
fix: updateFertilizerFromCatalogue silently wipes existing type flags
SvenVw e2773a9
nitpicks
SvenVw 23bced7
fix
SvenVw b36b09f
Merge branch 'development' into add-application-method
SvenVw ed7cd2d
Merge branch 'development' into add-application-method
SvenVw 955f854
fix: unit conversion at calculation of N supply by other fertilizers
SvenVw a5bd600
fix: inserting pseudocolumn
SvenVw 3e339fd
fix: remove double conversion
SvenVw 86e777d
fix: copy errors in name
SvenVw a2bd823
fix: unit
SvenVw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-app": minor | ||
| --- | ||
|
|
||
| Display the application method for each fertilizer application in the list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-calculator": patch | ||
| --- | ||
|
|
||
| Fix unit conversion at calculation of N supply by other fertilizers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-app": patch | ||
| --- | ||
|
|
||
| Replace the `p_type_*` boolean flags with the unified `p_type` field across all fertilizer functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-data": minor | ||
| --- | ||
|
|
||
| Add `p_app_method_options` as parameter of Fertilizer Catalogue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-core": patch | ||
| --- | ||
|
|
||
| Fixes a bug in `syncCatalogue` where, when an item already exists but its hash has changed, the other properties were not updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-app": minor | ||
| --- | ||
|
|
||
| Add a feature to select an existing fertilizer as a template for new fertilizers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-app": minor | ||
| --- | ||
|
|
||
| Improve the design of the fertilizer form page by making it more intuitive and clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-data": minor | ||
| --- | ||
|
|
||
| Expose the `ApplicationMethods` union type in the `@svenvw/fdm-data` package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-core": minor | ||
| --- | ||
|
|
||
| Add the new function `getSoilParameterDescription` to obtain details about fertilizer parameters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-app": minor | ||
| --- | ||
|
|
||
| Add an application-method field to the fertilizer-application form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@svenvw/fdm-core": minor | ||
| --- | ||
|
|
||
| Add the parameter `p_app_method_options` to `fertilizer_catalogue` to represent the possible methods that can be used to apply the fertilizer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
fdm-app/app/components/blocks/fertilizer-applications/types.d.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.