Make shapefile upload less confusing#264
Closed
BoraIneviNMI wants to merge 3 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 021c257 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughAdds calendar-year awareness across core and app: new getCalendarYears API in fdm-core and export; loader/UI changes to show a year dropdown on farm creation fields; upload flow records available years and redirects to a suitable year when needed; two changeset entries bump app and core. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as Fields Page (App)
participant Loader as Route Loader
participant Core as fdm-core.getCalendarYears
participant DB as DB
UI->>Loader: load(b_id_farm, calendar)
Loader->>Core: getCalendarYears(fdm, principal_id, b_id_farm)
Core->>DB: SELECT DISTINCT b_start WHERE farm = b_id_farm
DB-->>Core: dates[]
Core-->>Loader: ["2022","2023","2024"]
Loader-->>UI: { fields, calendar, calendarYears }
Note over UI: If >1 year, render dropdown
UI->>UI: On select year Y
UI->>UI: navigate /farm/create/{b_id_farm}/{Y}/fields
sequenceDiagram
autonumber
participant User as User
participant Upload as Upload Action
participant Proc as Feature Processor
participant Router as Redirect
User->>Upload: Submit shapefile (calendar=C)
Upload->>Proc: Parse features
Proc-->>Upload: years found = {Ymin..Ymax}
alt No parcels imported
Upload->>Router: redirectWithError(/fields for C)
else Requested C not in years
Upload->>Upload: redirectCalendar = clamp(C, [Ymin,Ymax])
Upload->>Router: redirectWithSuccess(/fields for redirectCalendar)
else C available
Upload->>Router: redirectWithSuccess(/fields for C)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #264 +/- ##
===============================================
- Coverage 92.77% 92.57% -0.20%
===============================================
Files 87 87
Lines 13030 13058 +28
Branches 1289 1289
===============================================
Hits 12089 12089
- Misses 939 967 +28
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coderabbitai
Bot
added
branch:development
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (7)
.changeset/ten-days-joke.md (1)
6-6: Fix wording and casing in the changeset note.Grammatical nit and product name casing.
-When an user uploads their shapefile obtained from mijnpercelen, they are now redirected to a different year in case the farm doesn't have any fields from the current year still. +When a user uploads a shapefile from MijnPercelen, the app redirects to a different year if the farm has no fields in the current year..changeset/polite-falcons-sniff.md (1)
6-6: Tighten phrasing and use consistent “dropdown”.Pure copy edit.
-There is a new year selection drop-down in the farm creation fields page in case the farm has fields from multiple years. +Adds a year selection dropdown on the farm creation fields page for farms with fields in multiple years.fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsx (2)
177-181: Rename Select name to reflect value.This isn’t a form submit, but if you keep name, prefer “calendar” over “role”.
- <Select - defaultValue={loaderData.calendar} - name="role" - onValueChange={handleCalendarSelect} - > + <Select + defaultValue={loaderData.calendar} + name="calendar" + onValueChange={handleCalendarSelect} + >
189-199: Defensively dedupe and sort years to avoid duplicate options/keys.If the API ever returns duplicates, this prevents UI duplication and React key warnings.
- {loaderData.calendarYears.map( - (year) => ( - <SelectItem - key={year} - value={year} - > - {year} - </SelectItem> - ), - )} + {Array.from(new Set(loaderData.calendarYears)) + .sort() + .map((year) => ( + <SelectItem key={year} value={year}> + {year} + </SelectItem> + ))}fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx (3)
183-186: Type the Set for clarity and correctness.Makes intent explicit and prevents accidental mixing of strings/numbers.
- const calendarYears = new Set() + const calendarYears = new Set<number>() let minCalendarYear = Number.POSITIVE_INFINITY let maxCalendarYear = 0
268-271: Use UTC year to avoid timezone off‑by‑one.Also standardize the Set to numbers.
- calendarYears.add(b_start.getFullYear().toString()) - minCalendarYear = Math.min(minCalendarYear, b_start.getFullYear()) - maxCalendarYear = Math.max(maxCalendarYear, b_start.getFullYear()) + const y = b_start.getUTCFullYear() + calendarYears.add(y) + minCalendarYear = Math.min(minCalendarYear, y) + maxCalendarYear = Math.max(maxCalendarYear, y)
273-281: Likely unreachable branch.Given earlier validation and loop,
calendarYears.size === 0seems impossible if features exist. Safe to keep, but consider removing to simplify.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.changeset/polite-falcons-sniff.md(1 hunks).changeset/ten-days-joke.md(1 hunks)fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsx(6 hunks)fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx(3 hunks)fdm-core/src/farm.ts(1 hunks)fdm-core/src/index.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (11)
📚 Learning: 2025-01-09T16:03:37.764Z
Learnt from: SvenVw
PR: SvenVw/fdm#42
File: fdm-app/app/routes/farm/_b_id_farm/layout.tsx:46-95
Timestamp: 2025-01-09T16:03:37.764Z
Learning: A shared layout component `FarmLayoutBase` has been created in `components/custom/farm-layout-base.tsx` to maintain consistency across farm-related pages. The component handles farm selection dropdown, breadcrumb navigation, and provides a common layout structure.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsx
📚 Learning: 2025-08-11T12:24:32.200Z
Learnt from: SvenVw
PR: SvenVw/fdm#233
File: fdm-app/app/components/blocks/atlas-fields/cultivation-history.tsx:53-53
Timestamp: 2025-08-11T12:24:32.200Z
Learning: In `fdm-app/app/components/blocks/atlas-fields/cultivation-history.tsx`, the NMI API for cultivations guarantees that each year will be unique in the cultivation history data, so using `cultivation.year` as a React list key is safe and won't cause duplicate key warnings.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-04-18T13:49:17.029Z
Learnt from: SvenVw
PR: SvenVw/fdm#124
File: fdm-app/app/components/custom/farm/farm-title.tsx:3-3
Timestamp: 2025-04-18T13:49:17.029Z
Learning: In the fdm project, NavLink and other routing components can be imported from either "react-router" or "react-router-dom" as react-router-dom is included in react-router.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2024-12-16T10:56:07.561Z
Learnt from: SvenVw
PR: SvenVw/fdm#16
File: fdm-app/app/routes/app.addfarm.$b_id_farm.cultivations.$b_lu_catalogue.fertilizers.tsx:1-1
Timestamp: 2024-12-16T10:56:07.561Z
Learning: The project uses `react-router` v7, and the `data` function is exported and used for error handling in loaders and actions.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-01-09T16:03:37.764Z
Learnt from: SvenVw
PR: SvenVw/fdm#42
File: fdm-app/app/routes/farm/_b_id_farm/layout.tsx:46-95
Timestamp: 2025-01-09T16:03:37.764Z
Learning: The `FarmLayout` component in `components/custom/farm-layout.tsx` provides a reusable layout structure for farm-related pages, with support for farm selection dropdown, customizable breadcrumb titles, and flexible content rendering through either children or Outlet components.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsx
📚 Learning: 2025-05-09T14:53:44.578Z
Learnt from: SvenVw
PR: SvenVw/fdm#138
File: fdm-app/app/components/custom/combobox.tsx:34-37
Timestamp: 2025-05-09T14:53:44.578Z
Learning: In the context of this React Router v7 project, it's important to follow the pattern of importing only the types (like UseFormReturn) from "react-hook-form" while importing the Form component from "react-router" to avoid naming conflicts.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-05-09T14:41:43.484Z
Learnt from: SvenVw
PR: SvenVw/fdm#138
File: fdm-app/app/components/custom/fertilizer-applications/form.tsx:6-6
Timestamp: 2025-05-09T14:41:43.484Z
Learning: The project uses React Router v7 which exports a Form component directly from the "react-router" package, not from "remix-run/react".
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-05-09T14:41:43.484Z
Learnt from: SvenVw
PR: SvenVw/fdm#138
File: fdm-app/app/components/custom/fertilizer-applications/form.tsx:6-6
Timestamp: 2025-05-09T14:41:43.484Z
Learning: The project uses React Router v7 which exports a Form component directly from the "react-router" package, making importing from "remix-run/react" unnecessary.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsxfdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-06-02T10:31:27.097Z
Learnt from: SvenVw
PR: SvenVw/fdm#151
File: fdm-app/app/routes/signin._index.tsx:101-101
Timestamp: 2025-06-02T10:31:27.097Z
Learning: In fdm-app/app/routes/signin._index.tsx, the redirect destinations are intentionally inconsistent by design: the component defaults new sign-ins to "/welcome" (line 101) while the loader redirects authenticated users to "/farm" (line 80) and the action uses "/farm" as fallback (line 434). This creates appropriate user flows where new users complete their profile via the welcome page, while existing authenticated users bypass it and go directly to the main application.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-01-14T16:06:24.294Z
Learnt from: SvenVw
PR: SvenVw/fdm#45
File: fdm-app/app/routes/farm.$b_id_farm._index.tsx:1-1
Timestamp: 2025-01-14T16:06:24.294Z
Learning: In the fdm-app codebase, the `redirect` function should be imported from `react-router`, not `react-router-dom`.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
📚 Learning: 2025-01-14T16:06:21.832Z
Learnt from: SvenVw
PR: SvenVw/fdm#45
File: fdm-app/app/routes/farm.$b_id_farm.settings._index.tsx:1-1
Timestamp: 2025-01-14T16:06:21.832Z
Learning: In the fdm project, `redirect` and other routing utilities should be imported from `react-router` instead of `react-router-dom`.
Applied to files:
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx
🧬 Code graph analysis (2)
fdm-core/src/farm.ts (2)
fdm-core/src/index.ts (2)
getCalendarYears(60-60)FdmType(70-70)fdm-core/src/authorization.ts (1)
checkPermission(156-240)
fdm-app/app/routes/farm.create.$b_id_farm.$calendar.fields.tsx (2)
fdm-core/src/farm.ts (1)
getCalendarYears(87-116)fdm-core/src/index.ts (1)
getCalendarYears(60-60)
🔇 Additional comments (1)
fdm-core/src/index.ts (1)
60-60: LGTM: public export added.
Comment on lines
+282
to
296
| if (!calendarYears.has(calendar)) { | ||
| try { | ||
| const redirectCalendar = Math.max( | ||
| minCalendarYear, | ||
| Math.min(maxCalendarYear, Number.parseInt(calendar)), | ||
| ) | ||
|
|
||
| return redirectWithSuccess( | ||
| `/farm/create/${b_id_farm}/${redirectCalendar}/fields`, | ||
| { | ||
| message: `Geen percelen in ${calendar} zijn geïmporteerd. Je bekijkt nu de percelen in ${redirectCalendar}.`, | ||
| }, | ||
| ) | ||
| } catch (_) {} | ||
| } |
Contributor
There was a problem hiding this comment.
Clamping picks unavailable years; choose the nearest available year instead.
Current logic clamps to [min,max] but may still select a year that has no parcels (e.g., available {2018,2020,2022} and requested 2021 → 2021). Pick the closest available year.
Apply this diff:
- if (!calendarYears.has(calendar)) {
- try {
- const redirectCalendar = Math.max(
- minCalendarYear,
- Math.min(maxCalendarYear, Number.parseInt(calendar)),
- )
-
- return redirectWithSuccess(
- `/farm/create/${b_id_farm}/${redirectCalendar}/fields`,
- {
- message: `Geen percelen in ${calendar} zijn geïmporteerd. Je bekijkt nu de percelen in ${redirectCalendar}.`,
- },
- )
- } catch (_) {}
- }
+ if (!calendarYears.has(Number.parseInt(calendar, 10))) {
+ const years = Array.from(calendarYears).sort((a, b) => a - b)
+ const req = Number.parseInt(calendar, 10)
+ // Prefer the latest year <= requested; otherwise the earliest >= requested; fallback to most recent
+ const lower = years.filter((y) => y <= req).pop()
+ const higher = years.find((y) => y >= req)
+ const redirectCalendar = lower ?? higher ?? years[years.length - 1]
+
+ return redirectWithSuccess(
+ `/farm/create/${b_id_farm}/${redirectCalendar}/fields`,
+ {
+ message: `Geen percelen in ${calendar} zijn geïmporteerd. Je bekijkt nu de percelen in ${redirectCalendar}.`,
+ },
+ )
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if (!calendarYears.has(calendar)) { | |
| try { | |
| const redirectCalendar = Math.max( | |
| minCalendarYear, | |
| Math.min(maxCalendarYear, Number.parseInt(calendar)), | |
| ) | |
| return redirectWithSuccess( | |
| `/farm/create/${b_id_farm}/${redirectCalendar}/fields`, | |
| { | |
| message: `Geen percelen in ${calendar} zijn geïmporteerd. Je bekijkt nu de percelen in ${redirectCalendar}.`, | |
| }, | |
| ) | |
| } catch (_) {} | |
| } | |
| if (!calendarYears.has(Number.parseInt(calendar, 10))) { | |
| const years = Array.from(calendarYears).sort((a, b) => a - b) | |
| const req = Number.parseInt(calendar, 10) | |
| // Prefer the latest year <= requested; otherwise the earliest >= requested; fallback to most recent | |
| const lower = years.filter((y) => y <= req).pop() | |
| const higher = years.find((y) => y >= req) | |
| const redirectCalendar = lower ?? higher ?? years[years.length - 1] | |
| return redirectWithSuccess( | |
| `/farm/create/${b_id_farm}/${redirectCalendar}/fields`, | |
| { | |
| message: `Geen percelen in ${calendar} zijn geïmporteerd. Je bekijkt nu de percelen in ${redirectCalendar}.`, | |
| }, | |
| ) | |
| } |
🤖 Prompt for AI Agents
In fdm-app/app/routes/farm.create.$b_id_farm.$calendar.upload.tsx around lines
282-296, the code currently clamps the requested year to min/max which can still
select a year that has no parcels; instead compute the numeric requested year,
iterate the available calendarYears to find the single year with the smallest
absolute difference (tie-breaker: prefer the larger or smaller year? pick the
nearer; if equal choose the lower or higher consistently — pick the lower for
determinism), use that nearest available year as redirectCalendar, and return
redirectWithSuccess to `/farm/create/${b_id_farm}/${redirectCalendar}/fields`
with the same message; if calendarYears is empty fallback to the existing clamp
behavior or abort gracefully; remove the silent empty catch (or at least log the
error) so failures are visible.
Comment on lines
+75
to
+116
| /** | ||
| * Retrieves the calendar years during which the farm has fields, after verifying that the requesting principal has read access. | ||
| * | ||
| * This function checks the principal's permissions before querying the database for the farm identified by the provided ID. | ||
| * | ||
| * @param fdm The FDM instance providing the connection to the database. The instance can be created with {@link createFdmServer}. | ||
| * @param principal_id - The identifier of the principal making the request. | ||
| * @param b_id_farm - The unique identifier of the farm to retrieve. | ||
| * @returns A Promise that resolves with a string array of calendar years. | ||
| * @throws {Error} If permission checks fail or if an error occurs while retrieving the calendar years. | ||
| * @alpha | ||
| */ | ||
| export async function getCalendarYears( | ||
| fdm: FdmType, | ||
| principal_id: string, | ||
| b_id_farm: string, | ||
| ): Promise<string[]> { | ||
| try { | ||
| return await fdm.transaction(async (tx: FdmType) => { | ||
| await checkPermission( | ||
| tx, | ||
| "farm", | ||
| "read", | ||
| b_id_farm, | ||
| principal_id, | ||
| "getCalendarYears", | ||
| ) | ||
|
|
||
| const results = await tx | ||
| .selectDistinct({ b_start: schema.fieldAcquiring.b_start }) | ||
| .from(schema.fieldAcquiring) | ||
| .where(eq(schema.fieldAcquiring.b_id_farm, b_id_farm)) | ||
| .orderBy(asc(schema.fieldAcquiring.b_start)) | ||
|
|
||
| return results.map(({ b_start }) => | ||
| b_start.getFullYear().toString(), | ||
| ) | ||
| }) | ||
| } catch (err) { | ||
| throw handleError(err, "Exception for getCalendarYears") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Ensure unique, sorted years and avoid timezone drift.
Current query selects distinct b_start timestamps, then maps to years. Different dates within the same year will produce duplicate years; also .getFullYear() is locale‑dependent. Use UTC and dedupe/sort years before returning.
Apply this diff:
- const results = await tx
- .selectDistinct({ b_start: schema.fieldAcquiring.b_start })
- .from(schema.fieldAcquiring)
- .where(eq(schema.fieldAcquiring.b_id_farm, b_id_farm))
- .orderBy(asc(schema.fieldAcquiring.b_start))
-
- return results.map(({ b_start }) =>
- b_start.getFullYear().toString(),
- )
+ const results = await tx
+ .selectDistinct({ b_start: schema.fieldAcquiring.b_start })
+ .from(schema.fieldAcquiring)
+ .where(eq(schema.fieldAcquiring.b_id_farm, b_id_farm))
+
+ const years = Array.from(
+ new Set(results.map(({ b_start }) => b_start.getUTCFullYear())),
+ ).sort((a, b) => a - b)
+
+ return years.map(String)Also add minimal context to the error for parity with other methods:
- } catch (err) {
- throw handleError(err, "Exception for getCalendarYears")
- }
+ } catch (err) {
+ throw handleError(err, "Exception for getCalendarYears", {
+ b_id_farm,
+ principal_id,
+ })
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| /** | |
| * Retrieves the calendar years during which the farm has fields, after verifying that the requesting principal has read access. | |
| * | |
| * This function checks the principal's permissions before querying the database for the farm identified by the provided ID. | |
| * | |
| * @param fdm The FDM instance providing the connection to the database. The instance can be created with {@link createFdmServer}. | |
| * @param principal_id - The identifier of the principal making the request. | |
| * @param b_id_farm - The unique identifier of the farm to retrieve. | |
| * @returns A Promise that resolves with a string array of calendar years. | |
| * @throws {Error} If permission checks fail or if an error occurs while retrieving the calendar years. | |
| * @alpha | |
| */ | |
| export async function getCalendarYears( | |
| fdm: FdmType, | |
| principal_id: string, | |
| b_id_farm: string, | |
| ): Promise<string[]> { | |
| try { | |
| return await fdm.transaction(async (tx: FdmType) => { | |
| await checkPermission( | |
| tx, | |
| "farm", | |
| "read", | |
| b_id_farm, | |
| principal_id, | |
| "getCalendarYears", | |
| ) | |
| const results = await tx | |
| .selectDistinct({ b_start: schema.fieldAcquiring.b_start }) | |
| .from(schema.fieldAcquiring) | |
| .where(eq(schema.fieldAcquiring.b_id_farm, b_id_farm)) | |
| .orderBy(asc(schema.fieldAcquiring.b_start)) | |
| return results.map(({ b_start }) => | |
| b_start.getFullYear().toString(), | |
| ) | |
| }) | |
| } catch (err) { | |
| throw handleError(err, "Exception for getCalendarYears") | |
| } | |
| } | |
| /** | |
| * Retrieves the calendar years during which the farm has fields, after verifying that the requesting principal has read access. | |
| * | |
| * This function checks the principal's permissions before querying the database for the farm identified by the provided ID. | |
| * | |
| * @param fdm The FDM instance providing the connection to the database. The instance can be created with {@link createFdmServer}. | |
| * @param principal_id - The identifier of the principal making the request. | |
| * @param b_id_farm - The unique identifier of the farm to retrieve. | |
| * @returns A Promise that resolves with a string array of calendar years. | |
| * @throws {Error} If permission checks fail or if an error occurs while retrieving the calendar years. | |
| * @alpha | |
| */ | |
| export async function getCalendarYears( | |
| fdm: FdmType, | |
| principal_id: string, | |
| b_id_farm: string, | |
| ): Promise<string[]> { | |
| try { | |
| return await fdm.transaction(async (tx: FdmType) => { | |
| await checkPermission( | |
| tx, | |
| "farm", | |
| "read", | |
| b_id_farm, | |
| principal_id, | |
| "getCalendarYears", | |
| ) | |
| const results = await tx | |
| .selectDistinct({ b_start: schema.fieldAcquiring.b_start }) | |
| .from(schema.fieldAcquiring) | |
| .where(eq(schema.fieldAcquiring.b_id_farm, b_id_farm)) | |
| const years = Array.from( | |
| new Set(results.map(({ b_start }) => b_start.getUTCFullYear())), | |
| ).sort((a, b) => a - b) | |
| return years.map(String) | |
| }) | |
| } catch (err) { | |
| throw handleError(err, "Exception for getCalendarYears", { | |
| b_id_farm, | |
| principal_id, | |
| }) | |
| } | |
| } |
🤖 Prompt for AI Agents
In fdm-core/src/farm.ts around lines 75 to 116, the function returns distinct
b_start timestamps which can map to duplicate years and .getFullYear() can be
affected by local timezone; change the logic to extract the UTC year (e.g.,
using getUTCFullYear or equivalent) from each b_start, collect the years into a
Set to dedupe, convert to an array, sort ascending, and return that array of
unique string years; also include minimal context in the thrown error (e.g.,
"Exception for getCalendarYears: ") when rethrowing via handleError so it
parallels other methods.
Collaborator
Author
|
This was not the problem. Shapefile upload has to add cultivations to existing fields if possible. The getFields query might be wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores