Release/2025 09#282
Merged
Merged
Conversation
…ply of fertilizer application by interating only once over each fertilizer application
…onia emissions of fertilizer application by interating only once over each fertilizer application
…sition values by requesting more efficient the remote GeoTIFF
…many fields by organizing the calculations in batches
…ons are available
…and fix zero-day handling
Integrate Fertilizer Management into Farm Creation Wizard
Per-field norms errors, GeoTIFF refactor, derogatievrije zones support
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughBroad update across app and calculator: pnpm/tooling bumps; new fertilizer creation/management routes and components; field table/filter stores and UI; invitation email/response flow; farm dashboard and delete flow; nitrogen balance refactor with batched deposition; 2025 norms data/logic updates; map ref fitting; signin timezone capture; storage made SSR-safe; extensive tests added/adjusted; version/changelogs updated. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant AppRoute as Remix Route<br/>fertilizer.manage.new
participant Server as Loader/Action
participant Core as fdm-core/fdm-calculator
participant Store as FieldFertilizerFormStore
User->>AppRoute: Open "Add Fertilizer" UI
AppRoute->>Server: loader(request, params)
Server->>Core: getFarm/getFertilizers/getParameters
Core-->>Server: loaderData
Server-->>AppRoute: loaderData
AppRoute->>Store: load(b_id_farm, id)
alt Saved form exists
AppRoute->>AppRoute: Open dialog with saved values
end
User->>AppRoute: Submit form
AppRoute->>Server: action(formData, params)
Server->>Core: addFertilizerToCatalogue -> addFertilizer
Core-->>Server: new p_id
Server-->>AppRoute: redirect with toast
AppRoute->>Store: delete(b_id_farm, id)
sequenceDiagram
autonumber
actor User
participant Email as Invitation Email
participant Route as /organization.invitations/:id/respond
participant Server as Loader/Action
participant Org as Organization API
User->>Email: Click Accept/Reject link (with invitationId)
Email->>Route: GET ?intent=accept|reject
Route->>Server: loader(invitation_id)
Server->>Org: getPendingInvitation
Org-->>Server: Invitation data
Server-->>Route: loaderData
alt intent=accept
Route->>Server: action(intent=accept)
Server->>Org: acceptInvitation
Org-->>Server: OK
Server-->>Route: redirect to organization
else intent=reject
User->>Route: Submit Reject form
Route->>Server: action(intent=reject)
Server->>Org: rejectInvitation
Org-->>Server: OK
Server-->>Route: redirect to invitations
end
sequenceDiagram
autonumber
participant App as fdm-app Norms/N Balance
participant Calc as fdm-calculator
participant Public as Public Data (GeoTIFFs)
App->>Calc: collectInputForNitrogenBalance(...)
Calc->>Public: fetch GeoTIFFs (batch deposition, zones)
Public-->>Calc: values per field
Calc->>Calc: calculateAllFieldsNitrogenSupplyByDeposition
Calc->>Calc: calculateNitrogenBalanceField (sync, per field)
Calc-->>App: NitrogenBalance (numeric)
Estimated code review effort🎯 5 (Critical) | ⏱️ ~180 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (30)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 92.78% 93.26% +0.47%
==========================================
Files 87 81 -6
Lines 13045 13014 -31
Branches 1294 1306 +12
==========================================
+ Hits 12104 12137 +33
+ Misses 939 875 -64
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coderabbitai
Bot
added
branch:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
UI/UX
Documentation
Chores