Chore/20251104#326
Conversation
|
WalkthroughUpdates pnpm from 10.18.3 → 10.20.0 across GitHub Actions workflows and workspace package manifests; applies multiple minor/patch dependency bumps and a few Tailwind utility renames in UI components. No logic or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (8)📓 Common learnings📚 Learning: 2025-01-09T16:03:37.764ZApplied to files:
📚 Learning: 2025-01-09T16:03:37.764ZApplied to files:
📚 Learning: 2025-01-09T16:03:37.764ZApplied to files:
📚 Learning: 2025-01-09T16:03:37.764ZApplied to files:
📚 Learning: 2025-08-11T12:24:32.200ZApplied to files:
📚 Learning: 2025-04-18T13:49:17.029ZApplied to files:
📚 Learning: 2025-09-23T12:29:34.184ZApplied to files:
🧬 Code graph analysis (1)fdm-app/app/routes/farm.create.$b_id_farm.$calendar._index.tsx (1)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #326 +/- ##
===============================================
- Coverage 93.29% 87.68% -5.62%
===============================================
Files 96 69 -27
Lines 15356 3499 -11857
Branches 1561 973 -588
===============================================
- Hits 14326 3068 -11258
+ Misses 1028 431 -597
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coderabbitai
Bot
added
dependencies
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.github/workflows/deploy-docs-test.yml(1 hunks).github/workflows/deploy-docs.yml(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/tests.yml(3 hunks)fdm-app/package.json(4 hunks)fdm-calculator/package.json(1 hunks)fdm-core/package.json(3 hunks)fdm-data/package.json(1 hunks)fdm-docs/package.json(2 hunks)package.json(1 hunks)pnpm-workspace.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (17)
📓 Common learnings
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo.
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo. The catalog: syntax without a package name is the shorthand for referencing the default catalog.
📚 Learning: 2025-05-28T07:57:19.217Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo. The catalog: syntax without a package name is the shorthand for referencing the default catalog.
Applied to files:
pnpm-workspace.yamlfdm-data/package.jsonfdm-calculator/package.jsonfdm-core/package.json
📚 Learning: 2025-05-28T07:57:19.217Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo.
Applied to files:
pnpm-workspace.yamlfdm-data/package.jsonfdm-calculator/package.jsonfdm-core/package.json
📚 Learning: 2024-11-25T12:42:32.783Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 6
File: fdm-app/vite.config.ts:5-9
Timestamp: 2024-11-25T12:42:32.783Z
Learning: In the `fdm-app` project, SvenVw is preparing for migration to Remix v3 and may include type declarations or configurations for v3 features in advance, such as in `vite.config.ts`.
Applied to files:
pnpm-workspace.yamlfdm-app/package.json
📚 Learning: 2025-09-26T08:34:50.413Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 279
File: fdm-app/app/routes/farm.$b_id_farm.$calendar.norms.tsx:277-283
Timestamp: 2025-09-26T08:34:50.413Z
Learning: In the fdm project, fdm-core and fdm-app are updated together as part of a monorepo structure, which eliminates legacy data concerns when new fields like b_isproductive are introduced. Both packages are synchronized, so there's no need for defensive coding against undefined values for newly introduced database fields.
Applied to files:
fdm-app/package.jsonfdm-data/package.jsonfdm-calculator/package.jsonfdm-core/package.json
📚 Learning: 2025-01-14T16:06:21.832Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 45
File: fdm-app/app/routes/farm.$b_id_farm.settings._index.tsx:1-1
Timestamp: 2025-01-14T16:06:21.832Z
Learning: In the fdm project, `redirect` and other routing utilities should be imported from `react-router` instead of `react-router-dom`.
Applied to files:
fdm-app/package.json
📚 Learning: 2024-12-11T12:09:35.540Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 20
File: fdm-app/tsconfig.json:8-9
Timestamp: 2024-12-11T12:09:35.540Z
Learning: In the `fdm-app/tsconfig.json` file, the include path `.react-router/types/**/*` refers to a build-time generated directory which is intentionally not included in the repository.
Applied to files:
fdm-app/package.json
📚 Learning: 2024-12-16T10:48:27.598Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 16
File: fdm-app/package.json:40-40
Timestamp: 2024-12-16T10:48:27.598Z
Learning: In the `fdm-app/package.json` file, `remix-toast` and `sonner` are not duplicate dependencies. `remix-toast` manages toast generation and handling within the Remix framework, while `sonner` provides the actual implementation and UI of the toast notifications. They serve different purposes and are intended to be used together in the project.
Applied to files:
fdm-app/package.json
📚 Learning: 2025-01-14T16:06:24.294Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 45
File: fdm-app/app/routes/farm.$b_id_farm._index.tsx:1-1
Timestamp: 2025-01-14T16:06:24.294Z
Learning: In the fdm-app codebase, the `redirect` function should be imported from `react-router`, not `react-router-dom`.
Applied to files:
fdm-app/package.json
📚 Learning: 2025-04-18T13:49:17.029Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 124
File: fdm-app/app/components/custom/farm/farm-title.tsx:3-3
Timestamp: 2025-04-18T13:49:17.029Z
Learning: In the fdm project, NavLink and other routing components can be imported from either "react-router" or "react-router-dom" as react-router-dom is included in react-router.
Applied to files:
fdm-app/package.json
📚 Learning: 2025-05-09T14:41:43.484Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 138
File: fdm-app/app/components/custom/fertilizer-applications/form.tsx:6-6
Timestamp: 2025-05-09T14:41:43.484Z
Learning: The project uses React Router v7 which exports a Form component directly from the "react-router" package, not from "remix-run/react".
Applied to files:
fdm-app/package.json
📚 Learning: 2025-05-09T14:41:43.484Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 138
File: fdm-app/app/components/custom/fertilizer-applications/form.tsx:6-6
Timestamp: 2025-05-09T14:41:43.484Z
Learning: The project uses React Router v7 which exports a Form component directly from the "react-router" package, making importing from "remix-run/react" unnecessary.
Applied to files:
fdm-app/package.json
📚 Learning: 2025-10-15T08:11:10.649Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 299
File: fdm-docs/package.json:22-35
Timestamp: 2025-10-15T08:11:10.649Z
Learning: Docusaurus versions 3.7 and later support both React 18 and React 19. The peerDependencies are specified as "react": "^18.0.0 || ^19.0.0" and "react-dom": "^18.0.0 || ^19.0.0".
Applied to files:
fdm-app/package.jsonfdm-docs/package.json
📚 Learning: 2024-12-16T10:56:07.561Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 16
File: fdm-app/app/routes/app.addfarm.$b_id_farm.cultivations.$b_lu_catalogue.fertilizers.tsx:1-1
Timestamp: 2024-12-16T10:56:07.561Z
Learning: The project uses `react-router` v7, and the `data` function is exported and used for error handling in loaders and actions.
Applied to files:
fdm-app/package.json
📚 Learning: 2025-08-13T10:33:05.313Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 0
File: :0-0
Timestamp: 2025-08-13T10:33:05.313Z
Learning: In the fdm project, fdm-calculator integration for new features like b_lu_variety is handled in separate updates from the core data model changes. When fdm-core functions are updated to support new fields, fdm-calculator can consume these enhanced APIs without requiring changes in the same PR that introduces the core functionality.
Applied to files:
fdm-data/package.jsonfdm-calculator/package.jsonfdm-core/package.json
📚 Learning: 2025-01-31T15:05:14.310Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 67
File: fdm-app/app/routes/farm.create.$b_id_farm.fields.$b_id.tsx:601-610
Timestamp: 2025-01-31T15:05:14.310Z
Learning: The `updateField` function in fdm-core has optional parameters after `fdm` and `b_id`. The TypeScript definitions might show 8 required parameters due to a potential version mismatch.
Applied to files:
fdm-core/package.json
📚 Learning: 2025-01-24T11:46:49.990Z
Learnt from: SvenVw
Repo: SvenVw/fdm PR: 49
File: fdm-data/rollup.config.js:7-17
Timestamp: 2025-01-24T11:46:49.990Z
Learning: When suggesting external dependencies in Rollup configuration, only include packages that are actually listed in the package's dependencies or peerDependencies.
Applied to files:
fdm-core/package.json
🔇 Additional comments (14)
.github/workflows/deploy-docs.yml (1)
38-41: pnpm version upgrade is consistent with repository-wide tooling changes.The version bump aligns with the packageManager field updates in the workspace package.json files.
fdm-docs/package.json (1)
27-27: Dependency updates are safe and consistent across the monorepo.Minor version bump for lucide-react (0.552.0) and pnpm version alignment (10.20.0) are both standard maintenance updates.
Also applies to: 56-56
.github/workflows/deploy-docs-test.yml (1)
35-38: pnpm version is consistent with repository-wide upgrades.Aligns with parallel updates in other workflows and workspace packages.
fdm-calculator/package.json (1)
64-64: pnpm version update maintains consistency across the workspace..github/workflows/release.yml (1)
29-32: pnpm version upgrade is consistent across CI/CD workflows..github/workflows/tests.yml (1)
53-56: pnpm version updates are consistent across all test jobs.All three test jobs (test-core, test-calculator, test-data) align with the repository-wide pnpm 10.20.0 upgrade.
Also applies to: 146-149, 226-229
fdm-data/package.json (1)
60-60: pnpm version update aligns with workspace consistency.fdm-core/package.json (1)
54-54: Dependency updates are safe and follow semver compatibility.Patch and minor version bumps for @types/node, globals, and @electric-sql/pglite are all backward-compatible maintenance updates. The pnpm version aligns with workspace consistency.
Also applies to: 58-58, 67-67, 77-77
fdm-app/package.json (4)
114-114: ✓ pnpm package manager version updated correctly.packageManager updated to pnpm@10.20.0 consistently across the workspace, matching the root package.json (line 32). This ensures all workspace packages use the same pnpm version.
31-31: React Router v7.9.5 compatibility verified—no issues found.All verification checks passed:
- No legacy imports: Zero occurrences of
remix-run/reactorremix-run/remiximports.- Correct v7 patterns: All
redirect,Form,useLoaderData, anduseNavigateimports source from"react-router".- Action/loader exports: All use correct v7 syntax (
export async function loader/action).- Form usage: React Router
Formcomponent is properly imported from"react-router"across the codebase. SecondaryFormimport from"react-hook-form"in one file serves a different purpose and creates no conflicts.- Package versions: Correctly pinned to
^7.9.5for bothreact-routerandreact-router-dom.The codebase is ready for React Router v7.9.5.
69-69: No compatibility concerns—versions are compatible.remix-hook-form 7.1.1 is compatible with react-hook-form 7.66.0 since remix-hook-form is a wrapper targeting the react-hook-form v7 API, and any react-hook-form 7.x release should work. The exact version pinning of remix-hook-form is a standard practice and does not indicate compatibility issues.
54-54: I'll now verify the remaining libraries mentioned in the review comment.I need to search for more specific information about posthog-js 1.285.1 to complete the verification.
No breaking changes found in library updates—verification complete.
All five libraries have been checked and their release notes show only bug fixes and minor feature additions, not breaking changes. mapbox-gl 3.16.0 has no documented breaking changes, lucide-react 0.552.0 shows icon improvements without breaking API changes, nanoid 5.1.6 includes only non-breaking fixes, posthog-js 1.285.1 contains minor updates, and isbot 5.1.32 is a stable minor version update.
The code changes are safe to merge with respect to these library updates.
pnpm-workspace.yaml (1)
9-26: Fix incompatibility between vite 7.1.12 and @rollup/plugin-commonjs version.Vite 7.1.12 downgrades @rollup/plugin-commonjs to 28.0.6 to avoid regressions, but the catalog pins it to
^29.0.0at line 10. This mismatch will cause build failures. Update@rollup/plugin-commonjsto^28.0.6or lower to align with vite's requirements.⛔ Skipped due to learnings
Learnt from: SvenVw Repo: SvenVw/fdm PR: 147 File: fdm-docs/package.json:39-39 Timestamp: 2025-05-28T07:57:19.217Z Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo. The catalog: syntax without a package name is the shorthand for referencing the default catalog.Learnt from: SvenVw Repo: SvenVw/fdm PR: 147 File: fdm-docs/package.json:39-39 Timestamp: 2025-05-28T07:57:19.217Z Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo.Learnt from: SvenVw Repo: SvenVw/fdm PR: 134 File: fdm-calculator/package.json:44-46 Timestamp: 2025-05-26T09:39:31.123Z Learning: When analyzing npm package versions in package.json files, the specified versions are often already the latest stable versions, especially in active projects. Always verify with npm registry before suggesting version updates.package.json (1)
28-28: No breaking changes detected—upgrades are safe to proceed.All three tool upgrades are backward compatible with no breaking changes documented:
- Biome 2.3.0 introduces minor and patch changes and new features with no explicit breaking changes
- Turborepo v2.6.0 has no breaking changes documented; it adds new features (microfrontends, Bun support, task search)
- pnpm 10.20.0 has no breaking changes; it includes only patch fixes and minor features
coderabbitai
Bot
added
the
branch:development
1 participant
Summary by CodeRabbit
Chores
Style