Skip to content

Chore/20260330#535

Merged
SvenVw merged 4 commits into
developmentfrom
chore/20260330
Mar 31, 2026
Merged

Chore/20260330#535
SvenVw merged 4 commits into
developmentfrom
chore/20260330

Conversation

@SvenVw
Copy link
Copy Markdown
Collaborator

@SvenVw SvenVw commented Mar 30, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Established Node.js v24 as the minimum supported runtime version
    • Updated pnpm package manager from 10.32.1 to 10.33.0
    • Upgraded dependencies and development toolchain across all packages
    • Updated build configurations to target newer runtime environments
    • Refreshed icon component used in the authentication page

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

This PR updates the minimum Node.js engine requirement to version 24 across multiple packages, upgrades pnpm from 10.32.1 to 10.33.0 throughout the monorepo's workflows and package manifests, updates build targets to match Node.js 24, bumps various dependencies, and replaces a GitHub icon component in the signin route.

Changes

Cohort / File(s) Summary
Release Metadata
.changeset/lazy-pillows-raise.md
Added changeset declaring patch releases for five packages with Node.js v24 minimum requirement.
GitHub Workflows - pnpm Setup
.github/workflows/deploy-docs-test.yml, .github/workflows/deploy-docs.yml, .github/workflows/release.yml, .github/workflows/typecheck.yml, .github/workflows/tests.yml
Updated pnpm version from 10.32.1 to 10.33.0 across all CI workflow configurations.
Build Configuration - Rollup Targets
fdm-calculator/rollup.config.js, fdm-core/rollup.config.js, fdm-data/rollup.config.js, fdm-rvo/rollup.config.js
Changed esbuild JavaScript compilation target from node20 to node24 to align with updated Node.js engine requirement.
Package Manifests - Engine & pnpm Updates
fdm-calculator/package.json, fdm-core/package.json, fdm-data/package.json, fdm-docs/package.json, fdm-rvo/package.json, package.json
Updated Node.js engine requirement to >=24.0.0 across packages, bumped pnpm to 10.33.0 in packageManager field, and updated dev tool versions (@biomejs/biome, turbo).
App Dependencies & Configuration
fdm-app/package.json
Added @icons-pack/react-simple-icons dependency, bumped multiple package versions (React Email, React Router, Sentry, Tailwind, Framer Motion, etc.), and updated pnpm to 10.33.0.
Frontend Component & Build
fdm-app/app/routes/signin._index.tsx, fdm-app/vite.config.ts
Replaced GitHub icon from lucide-react with SiGithub from @icons-pack/react-simple-icons; changed Vite build target from ES2022 to baseline-widely-available.
Workspace Catalog Dependencies
pnpm-workspace.yaml
Updated shared catalog dependency versions for tooling packages (@dotenvx/dotenvx, @vitest/coverage-v8, better-auth, drizzle-kit, drizzle-orm, rollup, typedoc, vitest).
Documentation Package
fdm-docs/package.json
Upgraded lucide-react to ^1.7.0, bumped markdownlint-cli2 and typedoc-plugin-markdown, standardized Node.js engine constraint to >=24.0.0, and updated pnpm version.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

fdm-app, fdm-core, fdm-data, fdm-calculator, fdm-docs, dependencies, branch:development

Suggested reviewers

  • gerardhros
  • BoraIneviNMI

Poem

🐰 A rabbit hops through version trees,
Node twenty-four now sets us free,
Build targets dance, pnpm springs higher,
Dependencies shimmer like morning fire,
With icon swaps and configs aligned,
A smoother future we shall find!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Chore/20260330' is vague and generic, providing no meaningful information about the actual changes beyond using a date-based naming pattern. Consider using a more descriptive title that summarizes the main changes, such as 'chore: bump pnpm to 10.33.0 and set minimum Node.js to v24' or a similar summary of the primary objectives.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/20260330

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link
Copy Markdown

sentry Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/lazy-pillows-raise.md:
- Around line 2-9: The changeset currently marks several packages
("@nmi-agro/fdm-calculator", "@nmi-agro/fdm-core", "@nmi-agro/fdm-data",
"@nmi-agro/fdm-docs", "@nmi-agro/fdm-app") as "patch" while the content declares
a breaking change (dropping Node.js < v24); update the release type for each
listed package in .changeset/lazy-pillows-raise.md from "patch" to "major" so
the changeset publishes as a major release and reflects the breaking change.

In `@fdm-app/package.json`:
- Line 57: The spinner component imports a non-existent symbol Loader2Icon from
lucide-react; update the import in spinner.tsx to import Loader2 (no "Icon"
suffix) instead of Loader2Icon so it matches lucide-react v1 export names, and
ensure any usages of Loader2Icon are renamed to Loader2 within the component.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3aef2618-25b3-4d6c-b5ac-383ce1c66f51

📥 Commits

Reviewing files that changed from the base of the PR and between b553eea and 6b00be9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (20)
  • .changeset/lazy-pillows-raise.md
  • .github/workflows/deploy-docs-test.yml
  • .github/workflows/deploy-docs.yml
  • .github/workflows/release.yml
  • .github/workflows/tests.yml
  • .github/workflows/typecheck.yml
  • fdm-app/app/routes/signin._index.tsx
  • fdm-app/package.json
  • fdm-app/vite.config.ts
  • fdm-calculator/package.json
  • fdm-calculator/rollup.config.js
  • fdm-core/package.json
  • fdm-core/rollup.config.js
  • fdm-data/package.json
  • fdm-data/rollup.config.js
  • fdm-docs/package.json
  • fdm-rvo/package.json
  • fdm-rvo/rollup.config.js
  • package.json
  • pnpm-workspace.yaml

Comment thread .changeset/lazy-pillows-raise.md
Comment thread fdm-app/package.json
@SvenVw SvenVw merged commit 35427f6 into development Mar 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant