Chore/20260330#535
Conversation
📝 WalkthroughWalkthroughThis PR updates the minimum Node.js engine requirement to version 24 across multiple packages, upgrades pnpm from 10.32.1 to 10.33.0 throughout the monorepo's workflows and package manifests, updates build targets to match Node.js 24, bumps various dependencies, and replaces a GitHub icon component in the signin route. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/lazy-pillows-raise.md:
- Around line 2-9: The changeset currently marks several packages
("@nmi-agro/fdm-calculator", "@nmi-agro/fdm-core", "@nmi-agro/fdm-data",
"@nmi-agro/fdm-docs", "@nmi-agro/fdm-app") as "patch" while the content declares
a breaking change (dropping Node.js < v24); update the release type for each
listed package in .changeset/lazy-pillows-raise.md from "patch" to "major" so
the changeset publishes as a major release and reflects the breaking change.
In `@fdm-app/package.json`:
- Line 57: The spinner component imports a non-existent symbol Loader2Icon from
lucide-react; update the import in spinner.tsx to import Loader2 (no "Icon"
suffix) instead of Loader2Icon so it matches lucide-react v1 export names, and
ensure any usages of Loader2Icon are renamed to Loader2 within the component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3aef2618-25b3-4d6c-b5ac-383ce1c66f51
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
.changeset/lazy-pillows-raise.md.github/workflows/deploy-docs-test.yml.github/workflows/deploy-docs.yml.github/workflows/release.yml.github/workflows/tests.yml.github/workflows/typecheck.ymlfdm-app/app/routes/signin._index.tsxfdm-app/package.jsonfdm-app/vite.config.tsfdm-calculator/package.jsonfdm-calculator/rollup.config.jsfdm-core/package.jsonfdm-core/rollup.config.jsfdm-data/package.jsonfdm-data/rollup.config.jsfdm-docs/package.jsonfdm-rvo/package.jsonfdm-rvo/rollup.config.jspackage.jsonpnpm-workspace.yaml
Summary by CodeRabbit
Release Notes