Remove RVO feature flag gating across fdm-app

[SvenVw]

Summary by CodeRabbit

• New Features

  • RVO field import via eHerkenning is now available to all users.

• Updates

  • UI and onboarding text consolidated and clarified to state parcels can be imported from RVO (shapefile or eHerkenning) with crop data populated automatically.
  • Minor wording corrections in RVO-related alerts and descriptions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 572c055c-3a8f-434c-afd7-28b140cd54bf

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa8a3a and 6673e0f.

📒 Files selected for processing (1)

• .changeset/good-peaches-wave.md

---

📝 Walkthrough

Walkthrough

Removed client-side PostHog feature-flag gating for the RVO import UI across multiple farm routes, making RVO import (including eHerkenning sign-in) available based on server isRvoConfigured only; also updated sign-in copy and added a changeset for a minor release.

Changes

Cohort / File(s)	Summary
Release Documentation \.changeset/good-peaches-wave.md	Added changeset declaring a minor release for @nmi-agro/fdm-app noting RVO import via eHerkenning is available to all users.
RVO Feature Routes fdm-app/app/routes/farm.$b_id_farm.$calendar.rvo.tsx, fdm-app/app/routes/farm.$b_id_farm._index.tsx, fdm-app/app/routes/farm.create.$b_id_farm.$calendar._index.tsx, fdm-app/app/routes/farm.create.$b_id_farm.$calendar.rvo.tsx	Removed useFeatureFlagEnabled("rvo") and related isRvoEnabled logic/early-return UIs; rendering now depends solely on server isRvoConfigured. Removed unused imports (CloudDownload, useFeatureFlagEnabled) and fixed a malformed alert text.
Sign-in Page fdm-app/app/routes/signin._index.tsx	Consolidated two paragraphs into one describing RVO parcel import either from an RVO shapefile or directly from RVO using eHerkenning; no logic changes.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add RVO field synchronization package and import workflows #374 — Modifies RVO route components and related farm UI that are simplified here.
• Remove RVO feature flag gating across fdm-app #586 — Removes the same client-side useFeatureFlagEnabled("rvo") gating across matching routes.
• Add RVO feature flag to control field import functionality #542 — Previously added PostHog feature-flag checks and early-return UI that this PR reverts.

Suggested labels

fdm-app, enhancement, branch:development

Suggested reviewers

• BoraIneviNMI
• gerardhros

Poem

🐰 The flags have hopped away today,
RVO fields now find their way.
eHerkenning bounces open wide,
Parcels hop in, no gate to hide. 🌿✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title Check	✅ Passed	Title check skipped as CodeRabbit has written the PR title.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/make-rvo-download-available

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sentry]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[SvenVw]

@coderabbitai resume

[coderabbitai]

✅ Actions performed

Reviews resumed.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/good-peaches-wave.md:
- Line 5: Update the release note line that currently reads "Importing fields
from RVO with the eHerkenning sign in is now available for all users" to
hyphenate the compound noun/adjective; change "sign in" to "sign-in" so the
sentence reads "Importing fields from RVO with the eHerkenning sign-in is now
available for all users".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dc24d447-fab3-496f-bce5-9da75e34ce46

📥 Commits

Reviewing files that changed from the base of the PR and between a13edc9 and 2fa8a3a.

📒 Files selected for processing (6)

• .changeset/good-peaches-wave.md
• fdm-app/app/routes/farm.$b_id_farm.$calendar.rvo.tsx
• fdm-app/app/routes/farm.$b_id_farm._index.tsx
• fdm-app/app/routes/farm.create.$b_id_farm.$calendar._index.tsx
• fdm-app/app/routes/farm.create.$b_id_farm.$calendar.rvo.tsx
• fdm-app/app/routes/signin._index.tsx

[BoraIneviNMI]

Looks good.