Chore/20260428#591
Merged
Merged
Conversation
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates pnpm pins across CI and manifests, migrates React Email imports to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SignInPage
participant OAuthProvider
participant FdmCoreAuth
participant AppServer
User->>SignInPage: Click "Sign in with Microsoft"
SignInPage->>OAuthProvider: Redirect / OAuth flow
OAuthProvider->>SignInPage: Redirect callback with profile (may lack email)
SignInPage->>AppServer: Callback POST (profile)
AppServer->>FdmCoreAuth: Map profile (email←email|mail, name←name|displayName|email local-part, image←picture|image|null)
alt email missing
FdmCoreAuth-->>AppServer: Error "microsoft_no_email"
AppServer-->>SignInPage: Redirect ?error=microsoft_no_email
SignInPage->>User: Show Microsoft-specific guidance message
else email present
FdmCoreAuth-->>AppServer: Create/return user
AppServer-->>SignInPage: Set session / redirect to app
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 18 minutes and 49 seconds.Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
fdm-calculator/src/mineralization/builders.ts (1)
38-38: Resolve public export vs@internalTSDoc mismatch.
getMainCultivationis now part of the public API, but its docblock still marks it as internal. Please remove@internal(or keep it non-exported) to avoid contradictory generated docs.Suggested doc fix
- * `@internal`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@fdm-calculator/src/mineralization/builders.ts` at line 38, The TSDoc for the exported function getMainCultivation is marked `@internal` which conflicts with it being part of the public API; remove the `@internal` tag from the function's docblock in builders.ts (or alternatively stop exporting getMainCultivation) so the documentation and export visibility match—locate the doc comment immediately above the getMainCultivation declaration and update it accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pnpm-workspace.yaml`:
- Around line 11-22: The dependency bumps (typescript, typedoc, vitest) are
breaking CI/tests; update configs and package listings to restore compatibility:
pin or adjust package entries for '@types/node' and other needed `@types` in the
workspace manifest, update tsconfig.json compilerOptions to override new
TypeScript 6 defaults (explicitly set "strict": false or desired value, "types":
["node"], "target" and "module" to your previous values and set
"moduleResolution" to "node" or "nodenext" per codebase), update vitest.config.*
to satisfy Vitest 4 changes (adjust coverage config, mocking settings and ensure
Node >=20 compatibility), and update TypeDoc config/options to match 0.28
path/README handling; then run type-check and full test suite across the
workspace packages (fdm-core, fdm-calculator, fdm-data, fdm-rvo) and fix any
resulting type/test failures before merging.
---
Nitpick comments:
In `@fdm-calculator/src/mineralization/builders.ts`:
- Line 38: The TSDoc for the exported function getMainCultivation is marked
`@internal` which conflicts with it being part of the public API; remove the
`@internal` tag from the function's docblock in builders.ts (or alternatively stop
exporting getMainCultivation) so the documentation and export visibility
match—locate the doc comment immediately above the getMainCultivation
declaration and update it accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 58adba12-9cb1-409c-a7d7-3423effeb872
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (37)
.github/workflows/deploy-docs-test.yml.github/workflows/deploy-docs.yml.github/workflows/release.yml.github/workflows/tests.yml.github/workflows/typecheck.yml.npmrcfdm-agents/package.jsonfdm-app/app/components/blocks/email/farm-invitation-cancelled.tsxfdm-app/app/components/blocks/email/farm-invitation-role-updated.tsxfdm-app/app/components/blocks/email/farm-invitation.tsxfdm-app/app/components/blocks/email/invitation.tsxfdm-app/app/components/blocks/email/layout.tsxfdm-app/app/components/blocks/email/magic-link.tsxfdm-app/app/components/blocks/email/welcome.tsxfdm-app/app/lib/email.server.tsfdm-app/package.jsonfdm-calculator/package.jsonfdm-calculator/src/balance/nitrogen/index.tsfdm-calculator/src/balance/organic-matter/index.tsfdm-calculator/src/doses/calculate-dose.tsfdm-calculator/src/doses/get-dose-field.tsfdm-calculator/src/index.tsfdm-calculator/src/mineralization/builders.tsfdm-calculator/src/mineralization/index.tsfdm-core/package.jsonfdm-core/src/cultivation.tsfdm-core/src/index.tsfdm-data/package.jsonfdm-docs/blog/tags.ymlfdm-docs/docusaurus.config.tsfdm-docs/package.jsonfdm-docs/tsconfig.jsonfdm-docs/typedoc.jsonfdm-rvo/package.jsonpackage.jsonpnpm-workspace.yamltsconfig.typedoc.json
…ask users to use the magic link instead
BoraIneviNMI
approved these changes
Apr 29, 2026
Collaborator
BoraIneviNMI
left a comment
BoraIneviNMI
left a comment
There was a problem hiding this comment.
Everything seems to be configured correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation
Bug Fixes
New Features