Repository navigation
feat: expose prepared operations for borrowed streaming transports - #1
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback-based HTTPS drivers lend response streams only while their connection is owned by the callback. Add prepared list, metadata, range and resumable-upload operations so those drivers can use the Drive protocol directly without returning an owned body or collecting a file in memory. Existing Transport and UploadTransport methods delegate to the same planners and acceptors, preserving their API and validation.
Prepared uploads expose bounded sources that track consumption, reject premature transport success, and keep the session probe-required after cancellation or a lost response. Borrowed responses retain exact range/EOF, metadata limits, redirect handling, session identity and acknowledgement rules. The README includes a compiled borrowed-body adapter example.
Validation with Rust 1.95.0: formatting, strict all-feature/all-target clippy, default and all-feature tests (39 core regressions plus hosted checks), documentation examples, and no_std ARM64/x86_64 UEFI checks. The existing manual loopback benchmark also passes with full payload validation.