Skip to content

feat: add responsive settings search - #121

Open
SyahrulBhudiF wants to merge 1 commit into
noFAYZ:mainfrom
SyahrulBhudiF:feat/settings-search
Open

SyahrulBhudiF wants to merge 1 commit into
noFAYZ:mainfrom
SyahrulBhudiF:feat/settings-search

Conversation

@SyahrulBhudiF

@SyahrulBhudiF SyahrulBhudiF commented Aug 26, 2026 •

Copy link
Copy Markdown

What and why

Adds a global Settings search field. It searches setting titles and descriptions across every Settings category, shows matching results with their category, and opens the selected category. The Settings layout now responds to the Settings pane width with container queries: narrow panes stack the header, make the search field full width, and turn the vertical category sidebar into a horizontal scrollable rail so settings cards retain usable content width.

image image

How it was checked

  • npm run verify passes — 33 checks passed
  • cargo test not required — no src-tauri/ files changed
  • npm run build passes
  • Search check covers empty, multi-term, category, and no-match queries
  • Screenshot or clip below (UI changes)

Notes for the reviewer

  • Search metadata is isolated in src/ui/components/settingsSearchIndex.ts; the page component only owns query state and category navigation.
  • The compact layout is a named container query, not a viewport breakpoint. It responds correctly when Settings is constrained by application chrome, window scaling, or an embedded pane.
  • Selecting a search result clears the query and opens its category.

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@SyahrulBhudiF is attempting to deploy a commit to the Faizan Asad's projects Team on Vercel.

A member of the Team first needs to authorize it.

@noFAYZ noFAYZ left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop PR_DESCRIPTION_SETTINGS_SEARCH.md, and the border border-border (the ui is borderless). the index is out of date too: the card is "Equaliser" now, and "hide status when paused" is from #119, which isn't merged.

Can you update?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants