feat: add responsive settings search - #121
Open
SyahrulBhudiF wants to merge 1 commit into
Open
SyahrulBhudiF wants to merge 1 commit into
SyahrulBhudiF wants to merge 1 commit into
Conversation
|
@SyahrulBhudiF is attempting to deploy a commit to the Faizan Asad's projects Team on Vercel. A member of the Team first needs to authorize it. |
noFAYZ
reviewed
Sep 23, 2026
Owner
There was a problem hiding this comment.
drop PR_DESCRIPTION_SETTINGS_SEARCH.md, and the border border-border (the ui is borderless). the index is out of date too: the card is "Equaliser" now, and "hide status when paused" is from #119, which isn't merged.
Can you update?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds a global Settings search field. It searches setting titles and descriptions across every Settings category, shows matching results with their category, and opens the selected category. The Settings layout now responds to the Settings pane width with container queries: narrow panes stack the header, make the search field full width, and turn the vertical category sidebar into a horizontal scrollable rail so settings cards retain usable content width.
How it was checked
npm run verifypasses — 33 checks passedcargo testnot required — nosrc-tauri/files changednpm run buildpassesNotes for the reviewer
src/ui/components/settingsSearchIndex.ts; the page component only owns query state and category navigation.