Skip to content

fix: added hours to playing time in seekbar - #127

Open
csarnataro wants to merge 1 commit into
noFAYZ:mainfrom
csarnataro:fix/fix-time-format-in-seekbar
Open

csarnataro wants to merge 1 commit into
noFAYZ:mainfrom
csarnataro:fix/fix-time-format-in-seekbar

Conversation

@csarnataro

Copy link
Copy Markdown

What and why

If a song lasts more than 1 hour, the format of the playing time is 'mm:ss', e.g. '160:00'.
It should be 'hh:mm:ss', e.g. '02:40:00' instead

Updated function formatMinutesSeconds to take into account hours.

Closes #126

How it was checked

  • npm run verify passes
  • Ran the app and used the affected screen
  • Screenshot or clip below (UI changes)

Before
Screenshot From 2026-09-03 16-21-49

After
image

Notes for the reviewer

I left the function name unchanged formatMinutesSeconds and not formatHoursMinutesSeconds because I think it's not much relevant.

At the moment if a song lasts more than 1 hour, the format of the playing time is 'mm:ss', e.g. '160:00'.
Instead it should be 'hh:mm:ss', e.g. '02:40:00'
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

@csarnataro is attempting to deploy a commit to the Faizan Asad's projects Team on Vercel.

A member of the Team first needs to authorize it.

@noFAYZ noFAYZ left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes every sub-hour time to 03:45, it should stay 3:45. also keep the Math.max(0, …) clamp, negatives now render -1:-5. and widen both time spans in SeekBar instead of mr-4.

Can you update?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong playing time format when songs are longer than 1 hour

2 participants