Add migration for AccountDepositWebhookRegistrations table#40
Closed
justinbarry wants to merge 2 commits intonoahsaso:mainfrom
Closed
Add migration for AccountDepositWebhookRegistrations table#40justinbarry wants to merge 2 commits intonoahsaso:mainfrom
justinbarry wants to merge 2 commits intonoahsaso:mainfrom
Conversation
* add self-registered deposit webhooks * add validator-backed deposit webhook CI test * Fix deposit webhook cache invalidation * Fix lint import order
The AccountDepositWebhookRegistration model was added without a corresponding migration, so fresh databases have no way to create the table. This adds the create-table migration matching the model.
Contributor
Author
|
Wrong repo — reopening against burnt-labs/dao-dao-indexer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountDepositWebhookRegistrationmodel was added in the deposit-webhook work without a corresponding Sequelize migration, so fresh databases have no way to create the table.Accounts.publicKeywith cascade, string/array columns with[]defaults,enableddefault true, timestamps, and indexes onaccountPublicKeyandenabled).Test plan
MIGRATING_DB=true npx sequelize-cli db:migrateapplies cleanly on a fresh DBdb:migrate:undorolls back cleanlyAccountDepositWebhookRegistrationtests still pass against the migrated schema