fix: copy package.json to dist/ for version.ts#44
Closed
Conversation
The version.ts file reads package.json relative to __dirname. When bundled with tsup, this resolves to dist/package.json but only package.json in root was being copied.
Collaborator
Author
|
Closing in favor of a cleaner fix using process.cwd() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 0.3.31 Docker image crashes with:
Cause
The
version.tsfile (added in #42) readspackage.jsonrelative to__dirname:When bundled with tsup,
__dirnameresolves to/app/dist, so it looks for/app/dist/../package.jsonwhich should work... but tsup's bundling changes path resolution.Fix
Copy
package.jsontodist/after building so it's available at runtime.