added APIs for v0 to v1 migration and swap (bridge) to be consumed by the extension#2
Open
Gohlub wants to merge 11 commits intofeat/wasm-module-version-bumpfrom
Open
added APIs for v0 to v1 migration and swap (bridge) to be consumed by the extension#2Gohlub wants to merge 11 commits intofeat/wasm-module-version-bumpfrom
Gohlub wants to merge 11 commits intofeat/wasm-module-version-bumpfrom
Conversation
Gohlub
force-pushed
the
feat/sdk-v0-and-bridge-APIs
branch
3 times, most recently
from
2060aa5 to
e1458d8
Compare
Made-with: Cursor
Gohlub
force-pushed
the
feat/sdk-v0-and-bridge-APIs
branch
from
e1458d8 to
c0101ac
Compare
h33p
requested changes
Mar 18, 2026
| import { base58 } from '@scure/base'; | ||
| import * as wasm from './wasm.js'; | ||
|
|
||
| function buildSinglePkhSpendCondition(pkh: string): SpendCondition { |
There was a problem hiding this comment.
Actual types from iris-wasm should be used, because pkh is a base58 encoded thing.
In alpha.9, I'm changing the types to not transparently cast from primitives.
|
|
||
| const txSettings = defaultTxEngineSettings(); | ||
| const targetSpendCondition = buildSinglePkhSpendCondition(targetV1Pkh); | ||
| const refundLock = wasm.locky(targetSpendCondition); |
| const feeNicks = builder.curFee(); | ||
| const transaction = builder.build(); | ||
| const allNotes = builder.allNotes(); | ||
| const rawTx: RawTxV1 = { |
There was a problem hiding this comment.
should use nockchainTxToRaw (there might be V1 somewhere in the name)
| }; | ||
| } | ||
|
|
||
| function defaultTxEngineSettings(): TxEngineSettings { |
There was a problem hiding this comment.
This should query things from the extension, but we don't have this information yet. So fine for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes v0 to v1 migration and bridge logic that will be consumed. It's dependent on #1 to be merged beforehand.