You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update to an existing plugin (version bumped in plugin.toml)
What it does
Switch EasyEffects output presets from a simple widget
External dependencies
easyeffects
Testing
Tested on Niri
Tested on Hyprland
Tested on Sway
Tested on another compositor:
Noctalia version tested against: 5.0.0_beta.8-1-dirty
Plugin API level: 3
Screenshots / Videos
Checklist
The directory name matches the part of id after the / in plugin.toml exactly.
It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
README.md follows the README template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
I did not edit catalog.toml; CI generates it.
This PR touches exactly one plugin directory.
Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
The code is readable and not obfuscated, minified, or generated.
It does not download and execute remote code.
Every network call, filesystem write, and spawned process is something the description above accounts for.
I have the right to publish this code under the license declared in plugin.toml.
The selected preset name is concatenated into a command passed to noctalia.runStream. Preset text comes from easyeffects -p without validation or shell escaping at easyeffects-presetctrl/picker.luau:54. runStream executes
the command through /bin/sh -c at ../noctalia-shell/src/scripting/luau_host.cpp:2381.
Double quotes do not prevent command substitution, and embedded quotes can break out of the quoted argument. A
crafted preset name can therefore execute arbitrary commands in the user's session when selected. Pass arguments
without a shell or apply complete shell escaping before execution.
The "Enable EasyEffects?" toggle only changes the local enabled variable and rerenders its label. It never enables,
disables, starts, or stops EasyEffects. The shipped control reports a state change that has no effect.
easyeffects-presetctrl/README.md:40 also identifies enable/disable as unfinished. Remove the control until
implemented, or connect it to the documented behavior.
The README documents show-glyph and show-label, but the manifest defines show_glyph and show_label at
easyeffects-presetctrl/plugin.toml:24 and easyeffects-presetctrl/plugin.toml:37. The documented setting names do not
match the plugin configuration keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
nuddel69/easyeffects-presetctrlplugin.toml)What it does
Switch EasyEffects output presets from a simple widget
External dependencies
easyeffectsTesting
Screenshots / Videos
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.