audio: add easyeffects profiles support#2915
Conversation
|
While on the topic, personally I think it would be also nice if the Easy Effects Sink could be hidden from the selectable output devices. |
|
Nice feature, and the EasyEffects side discovery looks well thought out (XDG paths, Flatpak, What worksThe Control Center rows make sense: show output/input presets when EasyEffects is actually there, hide them otherwise. IPC + OSD for What I'd changePull it out of Stop scanning the filesystem every frame. Ironically the active profile goes the other way - it's cached and only refreshed when the tab is created or you switch from Noctalia. So the list is hammered constantly but the selection can be wrong if you changed presets in EasyEffects itself. Socket I/O on the UI thread is probably fine for a click ( Smaller nits:
LucasOe's point about hiding the EasyEffects virtual sink from the device picker is fair, doesn't need to block this, but it's a natural follow-up. Before merge
Feature: yes. As written: needs another pass. |
|
@ItsLemmy Can you reopen this so that I can change the base branch to |
|
I had to recreate a v5 branch, so please do it quick if you can |
Base branch changed! However, I won't have time to finish this PR at least for a couple of days now. |
I'll mark is as a draft for now then :). |
|
@Ly-sec, new version ready for review. |
This commit adds support for switching between easyeffects profiles (output and input audio) if available.
Type of Change
Testing
Screenshots
Checklist