Repository navigation
release: final v2.2.2 hardening - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
policy_digestso replayed runs cannot lose the policy identity committed in the baseline record.ordealruns that record precomputed fixture responses still evaluate and honour policy before committing executed vs phantom entries.--nix-provenance=auto|onmay run bounded local Nix commands for diagnostic provenance while keeping provenance-only / witness-root invariants.2.2.2and add a short changelog entry.Description
replay_policy_digest: Option<String>toToolTranscript, setting it innew_replay(...), leaving itNoneinnew_live(...), and returning the preserved digest frominto_record()when present; this preservespolicy_digestduring replay. (changed:src/tooling.rs)ToolTranscript::execute_with_precomputed_response(...)which normalizes tool names, allocatestool_call_idxexactly once, evaluates the currentPolicyEnginebefore recording, recordsPhantomEntryonBlock/Phantom, and records actualToolCallonly onAllow; switchedrun_ordeallive path to use this method. (changed:src/tooling.rs,src/ordeal.rs)replay_preserves_policy_digest(replay digest preservation) and two ordeal tests verifying live precomputed responses under allow and block policies. (changed:tests/replay_phantom.rs,tests/ordeal.rs)--nix-provenance=auto|onmay run bounded local Nix commands for diagnostic provenance (closed stdin, timeout-bounded, output-capped) and does not alter witness root computation. (changed:README.md)Cargo.tomlpackage version set to2.2.2, root[[package]]entry inCargo.lockset to2.2.2, and conciseCHANGELOG.mdentry added for2.2.2. Dependency versions were not changed. (changed:Cargo.toml,Cargo.lock,CHANGELOG.md)Testing
cargo fmt --checksucceeded andcargo clippy --locked --all-targets -- -D warningssucceeded.cargo test --lockedsucceeded (all tests passed, including the new testsreplay_preserves_policy_digest,ordeal_live_precomputed_allow_records_executed_calls, andordeal_live_precomputed_block_records_phantom_not_entry).cargo run --locked -- ordeal check --golden goldens/ordeal_witness_root.txtsucceeded and matched the golden.cargo run --locked -- demo drift --seed 1 --threads 1 --fault-profile ci --out-dir demo_out --cleansucceeded and produced run outputs.cargo run --locked -- verify --witness demo_out/drift/baseline_faultsfailed in this ephemeral environment withfailed to read witness file (os error 2)due to CLI invocation expectations for the local demo output layout, whilecargo run --locked -- verify --witness demo_out/drift/baseline_faults --recompute-witness-rootsucceeded and confirmedmatched=trueon recompute.bash scripts/check_action_pins.shsucceeded (all actions pinned).cargo distvalidation:cargo distis not installed in this environment (no such command), socargo dist buildwas not run here and dist validation is deferred to the release/tag environment.Notes and non-goals (explicit)
Manual maintainer release instructions after merge
mainCI to pass.git tag -a v2.2.2 -m "Cogitator v2.2.2".git push origin v2.2.2.If any reviewer hits issues around witness roots or policy digests, treat them as P0 blockers (do not merge until resolved).
Codex Task