Get Windows Build Working#3
Open
zjgarvey wants to merge 1 commit into
Open
Conversation
Signed-off-by: Garvey <zagarvey@amd.com>
zjgarvey
requested review from
PhaneeshB,
Shukla-Gaurav,
stellaraccident and
vinayakdsci
vinayakdsci
requested changes
Aug 27, 2024
| onnx | ||
| protobuf::libprotobuf | ||
| ) | ||
| if ( CMAKE_COMPILER_IS_GNUCC ) |
There was a problem hiding this comment.
This variable appears to be deprecated in newer releases of CMake, so we might want to replace it with some newer alternative like CMAKE_C_COMPILER_ID.
Would you want this code to run only for GCC? Is there a reason for this?
Author
There was a problem hiding this comment.
Yeah, the flags here aren't recognized on windows cl. I'll look for a modern alternative to this.
vinayakdsci
pushed a commit
to vinayakdsci/onnxruntime
that referenced
this pull request
Sep 10, 2024
…oft#21528) ### Description Security fuzz test with address sanitizer found several bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the cmake options to conditionally exclude some
-Wno-somethingflags which cause problems with the windows build, makes some small changes tojit_compiler.ccto avoid other compiler errors on windows, and adds instructions for building on windows to the README.md.