Skip to content

feat: allow customizing CasbinRuleTable by providing optional argument #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hsluoyz merged 11 commits into from
Feb 14, 2025
Merged

feat: allow customizing CasbinRuleTable by providing optional argument #30

hsluoyz merged 11 commits into from
Feb 14, 2025

Conversation

@nagaozen
Copy link
Contributor

@nagaozen nagaozen commented Feb 14, 2025

No description provided.

@hsluoyz
Copy link
Member

hsluoyz commented Feb 14, 2025

@nodece @Shivansh-yadav13 please review

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nagaozen
Copy link
Contributor Author

nagaozen commented Feb 14, 2025

Tested by changing runner.ts line 42 to: const a = await BasicAdapter.newAdapter(drive, client, 'dbo.policies');.

image

Required update for keeping the database naming conventions.

@hsluoyz
Copy link
Member

hsluoyz commented Feb 14, 2025

@nagaozen you need to pass all CI checks:

image

@nagaozen
Copy link
Contributor Author

nagaozen commented Feb 14, 2025

I'm pretty sure the problem lies on the ci workflow. I will fix it

@nagaozen
Copy link
Contributor Author

nagaozen commented Feb 14, 2025 •
edited
Loading

@hsluoyz CI is fixed ... the problem is mostly related to using :latest versions. Therefore the project will keep breaking as the images bring breaking changes ... in another case, there wasn't a driver available for the latest OS version.

hsluoyz
hsluoyz requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@hsluoyz hsluoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the README too about the new usage

@nagaozen
Copy link
Contributor Author

nagaozen commented Feb 14, 2025

Custom Table Name Example created

@hsluoyz hsluoyz merged commit 514ab2a into node-casbin:master Feb 14, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
27fb5d6 
# [1.2.0](v1.1.0...v1.2.0) (2025-02-14)

### Features

* allow customizing `CasbinRuleTable` by providing optional argument ([#30](#30)) ([514ab2a](514ab2a))
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsluoyz hsluoyz hsluoyz approved these changes

@nodece nodece Awaiting requested review from nodece

@Shivansh-yadav13 Shivansh-yadav13 Awaiting requested review from Shivansh-yadav13

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nagaozen @hsluoyz @CLAassistant