Skip to content

Updating current mentors list. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeal merged 1 commit into from
Mar 9, 2016
Merged

Updating current mentors list. #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ at their own discretion.
help projects adopt and iterate on policies and processes that achieve
these goals and eventually allow them to graduate the incubation phase.

* Mikeal Rogers (@mikeal)
* Mikeal Rogers (@mikeal) Currently assigned to Express.

@orangemocha orangemocha Mar 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing @Fishrock123 ?

@mikeal mikeal Mar 2, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeremiah isn't assigned as a mentor to Express, he's an active contributor there.

@orangemocha orangemocha Mar 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize that.

* James Snell (@jasnell) Currently assigned to Express.
* Rod Vagg (@rvagg) Currently assigned to libuv.
* Alexis Campailla (@orangemocha) Currently assigned to libuv.

@orangemocha orangemocha Mar 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to remove the @ character, otherwise people will get notifications should this repo get forked. I would suggest using the same format as in https://github.com/nodejs/node#collaborators

@joshmanders joshmanders Mar 3, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know @ character does not ping a user in a .md file. It's just text there.

@orangemocha orangemocha Mar 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this works in detail. I know that I got tons of notifications from PRs like marekventur/dependency-updater#21 because my alias is in the readme.
In any case, it's not a huge issue either way :)

@orangemocha orangemocha Mar 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be a different issue though. Those PRs have my alias in the description, not the readme.

@joshmanders joshmanders Mar 3, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah your alias is in the issue body as a comment, which does ping the user and pull them into the issue as a subscriber, but in a repo README.md file it won't do that. Hope this clears it up for you. :)

@orangemocha orangemocha Mar 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks :) I remembered that we avoided it on the README of nodejs/node, but I don't remember the details of why we did that.
In any case, it's not a big deal and we can always fix it later if it becomes a problem.

And I assume you didn't get a notification for https://github.com/orangemocha/test/commit/9b51d8aa674de6bca3e2d785cd6099fbaaa2b6ce :)

@joshmanders joshmanders Mar 3, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not. :)

* Top-Level Projects
* Core TLP
* Core WGs (streams, http, Intl)
Expand Down