Skip to content

Implement a Remark Linter to validate Semantic Version strings in metadata #1109

Closed as not planned

Description

@moshams272

Enter your suggestions in details:

Currently, in packages/core/src/utils/generators.mjs, there is a @TODO regarding invalid Semantic Version strings.

I want to build a linting using unified-lint-rule (similar to how linting is handled in the nodejs.org repository: remark-lint/src/rules/yaml/index.mjs).

Activity

  1. avivkeller commented on Sep 23, 2026

    @avivkeller
    Member

    I think that TODO is outdated, we have lint rules to validate these in @node-core/remark-lint.

  2. moshams272 commented on Sep 23, 2026

    @moshams272
    ContributorAuthor

    So you keep doc-kit strictly as a build engine, and anyone who uses it can run their own linter independently if needed ?

  3. avivkeller commented on Sep 24, 2026

    @avivkeller
    Member

    Well, we have a @node-core/remark-lint linter (see nodejs/nodejs.org#9170), which lints doc-kit, but yes, doc-kit doesn't have a built-in linter (anymore)

  4. moshams272 commented on Sep 25, 2026

    @moshams272
    ContributorAuthor

    Oh, great work 🤍. BTW, if you'd like, I can remove this outdated comment in my next pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions