Skip to content

fix(html): fix the version picker on section pages and it blank state - #1112

Merged
ovflowd merged 1 commit into
nodejs:mainfrom
ryzrr:fix/version-picker-section
Sep 30, 2026
Merged

fix(html): fix the version picker on section pages and it blank state#1112
ovflowd merged 1 commit into
nodejs:mainfrom
ryzrr:fix/version-picker-section

Conversation

@ryzrr

@ryzrr ryzrr commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Description

The version picker on section pages linked to paths like latest-v24.x/api/fs/callback-api.html which exist in no release, so it now points at the module page and keeps the current version selected.

Validation

Simulated the dropdown .

Related Issues

Live on https://beta.docs.nodejs.org/fs/callback-api pick any version and you get a 404

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@ryzrr
ryzrr requested a review from a team as a code owner September 27, 2026 14:24
@vercel

vercel Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 30, 2026 6:58pm UTC

Request Review

@codecov

codecov Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.60%. Comparing base (932ca57) to head (387b723).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         244      244           
  Lines       22998    22998           
  Branches     2250     2250           
=======================================
  Hits        21297    21297           
  Misses       1692     1692           
  Partials        9        9

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 52.2% slower (900.00 ms → 1.37 s)
  • Peak memory: 4.0% lower (438.55 MB → 420.82 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 32.0% slower (6.94 s → 9.16 s)
  • Peak memory: 13.0% lower (1.70 GB → 1.48 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 9.0% slower (31.31 s → 34.13 s)
  • Peak memory: 6.6% lower (2.55 GB → 2.39 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 44.0% faster (8.72 s → 4.88 s)
  • Peak memory: 7.1% higher (1.62 GB → 1.73 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 5.8% faster (7.82 s → 7.37 s)
  • Peak memory: 8.0% higher (1.58 GB → 1.71 GB)

orama-db Generator

Output size: 1 file changed · net +150.00 B

File size details
File Main PR Change
orama-db.json 9.55 MB 9.55 MB +150.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 40.3% faster (8.52 s → 5.09 s)
  • Peak memory: 8.8% higher (1.77 GB → 1.92 GB)

web Generator

Output size: 128 files changed · net -1.92 KB

File size details
File Main PR Change
assets/SearchBox-CounBSE7.js 84.60 KB — -84.60 KB (-100.0%)
assets/SearchBox-Du_S-syB.js — 84.60 KB +84.60 KB
assets/dist-CgTHRSfN.js 30.42 KB — -30.42 KB (-100.0%)
assets/dist-2G5mhtO4.js — 30.42 KB +30.42 KB
assets/SideBar-CU3_pndT.js — 25.77 KB +25.77 KB
assets/SideBar-BpTWaVhj.js 25.70 KB — -25.70 KB (-100.0%)
assets/client-BPjlLezu.js 21.63 KB — -21.63 KB (-100.0%)
assets/client-CFtAXMNA.js — 21.63 KB +21.63 KB
assets/Combination-NqHZGC_F.js 16.12 KB — -16.12 KB (-100.0%)
assets/Combination-BHH_ioh9.js — 16.12 KB +16.12 KB
assets/ThemeToggle-BtW1BkAT.js 13.64 KB — -13.64 KB (-100.0%)
assets/ThemeToggle-Enx5fdQR.js — 13.64 KB +13.64 KB
assets/dist-Cgx7pOGB.js 10.20 KB — -10.20 KB (-100.0%)
assets/dist-CPvfBiOU.js — 10.20 KB +10.20 KB
assets/Layout-BjN6hpWl.js 10.14 KB — -10.14 KB (-100.0%)
assets/Layout-NSw7DrVm.js — 10.14 KB +10.14 KB
assets/compat-CdgPiiLx.js 10.12 KB — -10.12 KB (-100.0%)
assets/compat-kCdQKQ7m.js — 10.12 KB +10.12 KB
assets/Tooltip-AKP8LdlL.js 7.93 KB — -7.93 KB (-100.0%)
assets/Tooltip-C_86eILH.js — 7.93 KB +7.93 KB
assets/dist-Bl9Qg5Ug.js 6.99 KB — -6.99 KB (-100.0%)
assets/dist-C6NHxOZ3.js — 6.99 KB +6.99 KB
assets/jsx-runtime-6YqIbWBU.js 5.67 KB — -5.67 KB (-100.0%)
assets/jsx-runtime-dwDaSYdf.js — 5.67 KB +5.67 KB
assets/dist-BtoqWFFE.js 3.94 KB — -3.94 KB (-100.0%)
assets/dist-CBeEj7As.js — 3.94 KB +3.94 KB
assets/CodeTabs-C102uqDz.js 3.89 KB — -3.89 KB (-100.0%)
assets/CodeTabs-BmDFcWoq.js — 3.89 KB +3.89 KB
assets/CodeBox-Da-adK82.js 3.44 KB — -3.44 KB (-100.0%)
assets/CodeBox-CSPrf1UD.js — 3.44 KB +3.44 KB
assets/hooks.module-DS_fqR-L.js 3.40 KB — -3.40 KB (-100.0%)
assets/hooks.module-BHrNE9Pg.js — 3.40 KB +3.40 KB
assets/FunctionSignature-C8z8Mgvr.js 2.28 KB — -2.28 KB (-100.0%)
assets/FunctionSignature-BTQLWPEc.js — 2.28 KB +2.28 KB
assets/Banner-Uit0PTEJ.js 2.13 KB — -2.13 KB (-100.0%)
assets/Banner-BN7aMT_h.js — 2.13 KB +2.13 KB
assets/ChangeHistory-B_lqvQ2i.js 1.77 KB — -1.77 KB (-100.0%)
assets/ChangeHistory-CRqaN88c.js — 1.77 KB +1.77 KB
assets/DataTag-DhTo7f5P.js 844.00 B — -844.00 B (-100.0%)
assets/DataTag-JfD7iwHN.js — 844.00 B +844.00 B
assets/DocumentationIndex-CvaGu8mz.js 833.00 B — -833.00 B (-100.0%)
assets/DocumentationIndex-D7vAPtUv.js — 833.00 B +833.00 B
assets/ArrowUpRightIcon-BA1v6uIb.js 618.00 B — -618.00 B (-100.0%)
assets/ArrowUpRightIcon-DpjcpEje.js — 618.00 B +618.00 B
assets/Badge-D17sBn5n.js 607.00 B — -607.00 B (-100.0%)
assets/Badge-CQ-H8Zvm.js — 607.00 B +607.00 B
assets/AlertBox-sBM0705a.js 591.00 B — -591.00 B (-100.0%)
assets/AlertBox-CuX9J7lA.js — 591.00 B +591.00 B
assets/CodeBracketIcon-BIjXAcj-.js 512.00 B — -512.00 B (-100.0%)
assets/CodeBracketIcon-CIl_7xSS.js — 512.00 B +512.00 B
assets/dist-Ceae2CTM.js 477.00 B — -477.00 B (-100.0%)
assets/dist-gPf-8clp.js — 477.00 B +477.00 B
assets/ChevronDownIcon-edP1bUMq.js 468.00 B — -468.00 B (-100.0%)
assets/ChevronDownIcon-BxwIIRhZ.js — 468.00 B +468.00 B
assets/Blockquote-R3801o28.js 167.00 B — -167.00 B (-100.0%)
assets/Blockquote-BILsCj_9.js — 167.00 B +167.00 B
assets/useRemoteConfig-DFoVWnTz.js 149.00 B — -149.00 B (-100.0%)
assets/useRemoteConfig-DFM7_h_8.js — 149.00 B +149.00 B
assets/withIsland-BVqxZIfk.js 105.00 B — -105.00 B (-100.0%)
assets/withIsland-C9JOYjjL.js — 105.00 B +105.00 B
404.html 21.90 KB 21.87 KB -30.00 B (-0.1%)
addons.html 379.19 KB 379.16 KB -30.00 B (-0.0%)
all.html 33.01 MB 33.01 MB -30.00 B (-0.0%)
assert.html 650.82 KB 650.79 KB -30.00 B (-0.0%)
async_context.html 318.34 KB 318.31 KB -30.00 B (-0.0%)
async_hooks.html 283.61 KB 283.58 KB -30.00 B (-0.0%)
buffer.html 1.75 MB 1.75 MB -30.00 B (-0.0%)
child_process.html 674.81 KB 674.78 KB -30.00 B (-0.0%)
cli.html 631.57 KB 631.54 KB -30.00 B (-0.0%)
cluster.html 302.74 KB 302.71 KB -30.00 B (-0.0%)
console.html 185.16 KB 185.13 KB -30.00 B (-0.0%)
crypto.html 1.96 MB 1.96 MB -30.00 B (-0.0%)
debugger.html 143.46 KB 143.43 KB -30.00 B (-0.0%)
deprecations.html 564.45 KB 564.42 KB -30.00 B (-0.0%)
dgram.html 299.77 KB 299.74 KB -30.00 B (-0.0%)
diagnostics_channel.html 529.81 KB 529.78 KB -30.00 B (-0.0%)
dns.html 421.90 KB 421.87 KB -30.00 B (-0.0%)
documentation.html 28.55 KB 28.52 KB -30.00 B (-0.1%)
domain.html 126.91 KB 126.88 KB -30.00 B (-0.0%)
embedding.html 70.60 KB 70.57 KB -30.00 B (-0.0%)
environment_variables.html 37.69 KB 37.66 KB -30.00 B (-0.1%)
errors.html 530.83 KB 530.80 KB -30.00 B (-0.0%)
esm.html 187.11 KB 187.08 KB -30.00 B (-0.0%)
events.html 834.21 KB 834.18 KB -30.00 B (-0.0%)
fs.html 2.21 MB 2.21 MB -30.00 B (-0.0%)
globals.html 281.61 KB 281.58 KB -30.00 B (-0.0%)
http.html 1.14 MB 1.14 MB -30.00 B (-0.0%)
http2.html 1.25 MB 1.25 MB -30.00 B (-0.0%)
https.html 240.54 KB 240.51 KB -30.00 B (-0.0%)
index.html 26.74 KB 26.71 KB -30.00 B (-0.1%)
inspector.html 214.37 KB 214.34 KB -30.00 B (-0.0%)
intl.html 56.42 KB 56.39 KB -30.00 B (-0.1%)
module.html 510.36 KB 510.33 KB -30.00 B (-0.0%)
modules.html 227.47 KB 227.44 KB -30.00 B (-0.0%)
n-api.html 1.00 MB 1.00 MB -30.00 B (-0.0%)
net.html 633.42 KB 633.39 KB -30.00 B (-0.0%)
os.html 164.88 KB 164.85 KB -30.00 B (-0.0%)
packages.html 218.57 KB 218.54 KB -30.00 B (-0.0%)
path.html 177.30 KB 177.27 KB -30.00 B (-0.0%)
perf_hooks.html 866.72 KB 866.69 KB -30.00 B (-0.0%)
permissions.html 90.04 KB 90.01 KB -30.00 B (-0.0%)
process.html 1.14 MB 1.14 MB -30.00 B (-0.0%)
punycode.html 64.84 KB 64.82 KB -30.00 B (-0.0%)
querystring.html 66.98 KB 66.95 KB -30.00 B (-0.0%)
quic.html 924.14 KB 924.11 KB -30.00 B (-0.0%)
readline.html 363.68 KB 363.65 KB -30.00 B (-0.0%)
repl.html 303.01 KB 302.98 KB -30.00 B (-0.0%)
report.html 231.42 KB 231.39 KB -30.00 B (-0.0%)
single-executable-applications.html 159.44 KB 159.41 KB -30.00 B (-0.0%)
sqlite.html 520.05 KB 520.02 KB -30.00 B (-0.0%)
stream.html 1.22 MB 1.22 MB -30.00 B (-0.0%)
stream_iter.html 734.29 KB 734.26 KB -30.00 B (-0.0%)
string_decoder.html 66.22 KB 66.19 KB -30.00 B (-0.0%)
test.html 1.36 MB 1.36 MB -30.00 B (-0.0%)
timers.html 182.85 KB 182.82 KB -30.00 B (-0.0%)
tls.html 523.85 KB 523.82 KB -30.00 B (-0.0%)
tracing.html 126.07 KB 126.04 KB -30.00 B (-0.0%)
tty.html 107.25 KB 107.22 KB -30.00 B (-0.0%)
typescript.html 50.26 KB 50.23 KB -30.00 B (-0.1%)
url.html 512.50 KB 512.47 KB -30.00 B (-0.0%)
util.html 1.21 MB 1.21 MB -30.00 B (-0.0%)
v8.html 551.12 KB 551.09 KB -30.00 B (-0.0%)
vm.html 633.52 KB 633.49 KB -30.00 B (-0.0%)
wasi.html 80.33 KB 80.30 KB -30.00 B (-0.0%)
webcrypto.html 640.93 KB 640.90 KB -30.00 B (-0.0%)
webstreams.html 535.38 KB 535.35 KB -30.00 B (-0.0%)
worker_threads.html 634.84 KB 634.81 KB -30.00 B (-0.0%)
zlib.html 949.54 KB 949.51 KB -30.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 4.5% slower (62.70 s → 65.53 s)
  • Peak memory: 5.0% higher (3.06 GB → 3.21 GB)

@ovflowd

ovflowd commented Sep 30, 2026

Copy link
Copy Markdown
Member

@ryzrr could you rebase? 🙇

@ryzrr

ryzrr commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@ryzrr could you rebase? 🙇

Sure will do it in couple of hours , shortly

@ryzrr
fix(html): point the version picker at the module page on section pages
387b723 
Section pages exist only on the new site, so switching versions from /fs/callback-api gave a 404 on every release. The picker now also keeps the current version selected, so it no longer renders empty after going back.

Signed-off-by: Nikhil Kumar Rajak <ryzrr.official@gmail.com>
@ryzrr
ryzrr force-pushed the fix/version-picker-section branch from 885df6c to 387b723 Compare September 30, 2026 18:57
@ryzrr

ryzrr commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

PTAL!

@ovflowd
ovflowd merged commit 73f08d4 into nodejs:main Sep 30, 2026
24 checks passed

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 387b723b Deployed Sep 30, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowd ovflowd ovflowd approved these changes
@avivkeller avivkeller avivkeller approved these changes
@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryzrr @ovflowd @avivkeller @AugustinMauroy