add an all plaform supported cleanup solution#780
add an all plaform supported cleanup solution#780Vizonex wants to merge 5 commits intonodejs:mainfrom
Conversation
ShogunPanda
left a comment
There was a problem hiding this comment.
It looks fine to me.
Just two minor things:
- Can you move it to the scripts folder?
- Can you make sure it's properly formatted according to our linting rules?
|
I sure can, give me a couple of minutes. |
|
@ShogunPanda About what you told me I am in a bit of confusion as to what folder specifically to move this new
I had it in the |
|
@Vizonex My bad. I meant you to create a new |
|
Seems to be a little hiccup with linux. When using this script. I'm wondering if it's having problems with reaching the file or running it? |
|
@Vizonex Good question. Try with |
|
@ShogunPanda I fixed part of the script so that it resolves the items correctly but seems that linux is still not cooperating with me. |
There has been an ongoing issue for users using Windows who try and compile llhttp where the remove command
rmwouldn't work (because it doesn't exist on windows) so I came up a logical solution that tries to fix this and hopefully make it so that other users don't fall under the same boat.fixes #767