You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/node
console.log failure while working with worker threads. #30491
Invited
Loaders team: @nodejs/loaders
Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
how to make registerLoader happen (what the final API should look like, and what are the steps (ideally each step should be as small as possible, so we can delegate some of the work to e.g. first-time contributors looking for ideas on how to contribute)
how to make CJS loading from the ESM loader happen. I have a draft PR open which is at the POC stage, and I'm not going to complete the work by myself, so unless we're able to dispatch the work async, we could use the meeting time to discuss that. In any case, it would certainly be helpful if everyone interested could pull the PR locally and play with it (and bonus point if someone wants to contribute to testing all the crazy edge cases we'd need to have in mind).
Yes, let’s meet. Along with @aduh95’s list, there’s the issue of getting to work a load look returning source with type: 'commonjs'. @isaacs have you started working on that?
@aduh95 is that issue related to the “make CJS loading from the ESM loader” effort? Or put another way, would finishing your PR solve it?
I haven't started in earnest yet, but have been reading code and it's bubbling up my list swiftly. If @aduh95 or anyone else wants to get started, don't let me hold you back.
@aduh95 Can you share a link to the draft PR? I should have some time to poke at it in advance of the meeting.
Activity
JakobJingleheimer commentedon May 19, 2023
I think we have nothing to discuss? (I'm available if we do)
aduh95 commentedon May 19, 2023
There are two things that come to mind:
registerLoaderhappen (what the final API should look like, and what are the steps (ideally each step should be as small as possible, so we can delegate some of the work to e.g. first-time contributors looking for ideas on how to contribute)GeoffreyBooth commentedon May 19, 2023
Yes, let’s meet. Along with @aduh95’s list, there’s the issue of getting to work a
loadlook returningsourcewithtype: 'commonjs'. @isaacs have you started working on that?@aduh95 is that issue related to the “make CJS loading from the ESM loader” effort? Or put another way, would finishing your PR solve it?
aduh95 commentedon May 19, 2023
Yes, my PR goal is to run the code is a CJS-like environment when the
loadstep returns{ format: 'commonjs', source: … }.isaacs commentedon May 19, 2023
I haven't started in earnest yet, but have been reading code and it's bubbling up my list swiftly. If @aduh95 or anyone else wants to get started, don't let me hold you back.
@aduh95 Can you share a link to the draft PR? I should have some time to poke at it in advance of the meeting.
GeoffreyBooth commentedon May 19, 2023
nodejs/node#47999
JakobJingleheimer commentedon May 22, 2023
I think
registerLoaderis done in principle (there are just some test cases needed, which I'll get to in a few days if João doesn't get to it first).