Skip to content

Node.js Loaders Team Meeting 2023-05-23 #141

Closed as not planned
Closed as not planned

Description

@mhdawson

Time

UTC Tue 23-May-2023 18:00 (06:00 PM):

Timezone Date/Time
US / Pacific Tue 23-May-2023 11:00 (11:00 AM)
US / Mountain Tue 23-May-2023 12:00 (12:00 PM)
US / Central Tue 23-May-2023 13:00 (01:00 PM)
US / Eastern Tue 23-May-2023 14:00 (02:00 PM)
EU / Western Tue 23-May-2023 19:00 (07:00 PM)
EU / Central Tue 23-May-2023 20:00 (08:00 PM)
EU / Eastern Tue 23-May-2023 21:00 (09:00 PM)
Moscow Tue 23-May-2023 21:00 (09:00 PM)
Chennai Tue 23-May-2023 23:30 (11:30 PM)
Hangzhou Wed 24-May-2023 02:00 (02:00 AM)
Tokyo Wed 24-May-2023 03:00 (03:00 AM)
Sydney Wed 24-May-2023 04:00 (04:00 AM)

Or in your local time:

Links

Agenda

Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • console.log failure while working with worker threads. #30491

Invited

  • Loaders team: @nodejs/loaders

Observers/Guests

Notes

The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

Activity

  1. self-assigned this
    on May 19, 2023
  2. JakobJingleheimer commented on May 19, 2023

    @JakobJingleheimer
    Member

    I think we have nothing to discuss? (I'm available if we do)

  3. aduh95 commented on May 19, 2023

    @aduh95
    Contributor

    There are two things that come to mind:

    • how to make registerLoader happen (what the final API should look like, and what are the steps (ideally each step should be as small as possible, so we can delegate some of the work to e.g. first-time contributors looking for ideas on how to contribute)
    • how to make CJS loading from the ESM loader happen. I have a draft PR open which is at the POC stage, and I'm not going to complete the work by myself, so unless we're able to dispatch the work async, we could use the meeting time to discuss that. In any case, it would certainly be helpful if everyone interested could pull the PR locally and play with it (and bonus point if someone wants to contribute to testing all the crazy edge cases we'd need to have in mind).
  4. GeoffreyBooth commented on May 19, 2023

    @GeoffreyBooth
    Member

    Yes, let’s meet. Along with @aduh95’s list, there’s the issue of getting to work a load look returning source with type: 'commonjs'. @isaacs have you started working on that?

    @aduh95 is that issue related to the “make CJS loading from the ESM loader” effort? Or put another way, would finishing your PR solve it?

  5. aduh95 commented on May 19, 2023

    @aduh95
    Contributor

    Yes, my PR goal is to run the code is a CJS-like environment when the load step returns { format: 'commonjs', source: … }.

  6. isaacs commented on May 19, 2023

    @isaacs

    @isaacs have you started working on that?

    I haven't started in earnest yet, but have been reading code and it's bubbling up my list swiftly. If @aduh95 or anyone else wants to get started, don't let me hold you back.

    @aduh95 Can you share a link to the draft PR? I should have some time to poke at it in advance of the meeting.

  7. GeoffreyBooth commented on May 19, 2023

    @GeoffreyBooth
    Member

    @aduh95 Can you share a link to the draft PR? I should have some time to poke at it in advance of the meeting.

    nodejs/node#47999

  8. JakobJingleheimer commented on May 22, 2023

    @JakobJingleheimer
    Member

    I think registerLoader is done in principle (there are just some test cases needed, which I'll get to in a few days if João doesn't get to it first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions