You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trott
added
test
Issues and PRs related to Node.js core tests and test infrastructure.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
labels
Feb 2, 2017
Hmmm...oh, I think I see, this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?
this API is dictated elsewhere so we (probably) don't want to change it even if it might otherwise make sense to change it for our narrow use in our own tests?
Yeah, making this kind of subtle changes makes importing tests more difficult. Check out @joyeecheung's explanation (#11079 (comment)) for how WPTs are imported.
(Minimal doc stub for common.WPT here: #11127 If someone wants to do something more complete and informative, by all means, close that PR and open a better one.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testIssues and PRs related to Node.js core tests and test infrastructure.whatwg-urlIssues and PRs related to the WHATWG URL implementation.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test url