build: add --shared-hdr-histogram configure flag
#61280
Merged
+68
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
cjihrig
approved these changes
Jan 5, 2026
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61280 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 704 704
Lines 208739 208739
Branches 40190 40196 +6
=======================================
+ Hits 183692 183706 +14
+ Misses 16995 16992 -3
+ Partials 8052 8041 -11 🚀 New features to boost your workflow:
|
Collaborator
marco-ippolito
approved these changes
Jan 5, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
PR-URL: nodejs#61280 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95
force-pushed
the
shared-histogram
branch
from
502b5d5 to
842448b
Compare
Contributor
Author
|
Landed in 842448b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HdrHistogram is a dependency of libnode, it seems useful to be able to provide it as a shared dep instead of recompiling the vendored one.