Skip to content

tools: fix Nix diff tools when pushing more than 1 commit - #66383

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:nix-diff
Sep 30, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:nix-diff

Conversation

@aduh95

@aduh95 aduh95 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

We were using HEAD^, assuming we would only push 1 commit at a time, but that's obviously not always the case.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 28, 2026
@aduh95
aduh95 requested a review from panva September 29, 2026 22:34
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 30, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5e3bbc4 into nodejs:main Sep 30, 2026
32 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 5e3bbc4

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants