Conversation
mkdir(path, { recursive: true }) creates missing parent directories by
retrying whenever mkdir() fails with ENOENT, but nothing tracks
whether a retry actually made progress. If the same path keeps
failing with ENOENT even after its parent exists (e.g. under procfs,
or during a racing directory removal), the retry loops forever at
100% CPU with no way to interrupt a sync call.
Track the path last requeued after ENOENT in FSContinuationData and
clear it on a successful mkdir(). If the same path is retried again
with no progress since, fail with the original error instead of
looping. Applies to both MKDirpSync and MKDirpAsync.
Fixes: nodejs#66268
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
agape1225
force-pushed
the
fs-mkdirp-bound-enoent-retry
branch
from
September 30, 2026 10:08
1fb3404 to
b19049a
Compare
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66410 +/- ##
==========================================
+ Coverage 90.33% 90.37% +0.03%
==========================================
Files 790 792 +2
Lines 273834 275598 +1764
Branches 52361 52843 +482
==========================================
+ Hits 247378 249079 +1701
- Misses 16924 16938 +14
- Partials 9532 9581 +49
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdir(path, { recursive: true }) creates missing parent directories by retrying whenever mkdir() fails with ENOENT, but nothing tracks whether a retry actually made progress. If the same path keeps failing with ENOENT even after its parent exists (e.g. under procfs, or during a racing directory removal), the retry loops forever at 100% CPU with no way to interrupt a sync call.
Track the path last requeued after ENOENT in FSContinuationData and clear it on a successful mkdir(). If the same path is retried again with no progress since, fail with the original error instead of looping. Applies to both MKDirpSync and MKDirpAsync.
Fixes: #66268