Skip to content

tools: add cache to lint-js-and-md - #66412

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:cache-eslint-results
Open

aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:cache-eslint-results

Conversation

@aduh95

@aduh95 aduh95 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Assisted-by: Devin
Refs: #64972

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Sep 30, 2026
@panva

panva commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

attempt one has rate limit warnings

@aduh95

aduh95 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

attempt one has rate limit warnings

Unfortunately it looks like actions/cache does not handle that at all: actions/cache#1758
Still, seems to be worth it for the times it does hit the caches

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (8bf7793) to head (e4a6cfa).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66412      +/-   ##
==========================================
- Coverage   90.39%   90.37%   -0.02%     
==========================================
  Files         792      792              
  Lines      275580   275580              
  Branches    52840    52829      -11     
==========================================
- Hits       249104   249054      -50     
- Misses      16897    16948      +51     
+ Partials     9579     9578       -1     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 30, 2026
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue PRs queued for automated landing through the Commit Queue. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants