Skip to content

vfs: allow imports without the node: prefix - #66414

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:vfs-schemeless
Open

mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:vfs-schemeless

Conversation

@mcollina

Copy link
Copy Markdown
Member

The experimental VFS module previously required the node: prefix. Allow both vfs and node:vfs in CommonJS and ESM while keeping --experimental-vfs gating unchanged.

The vfs module this shadow currently managed by @ljharb, who told me it's ok.

The experimental VFS module previously required the node: prefix.
Allow both vfs and node:vfs in CommonJS and ESM while keeping
--experimental-vfs gating unchanged.

Assisted-by: Pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 30, 2026
@Renegade334

Copy link
Copy Markdown
Member

Was there a consensus from the node:test TSC discussion against exposing any new barenamed core modules from now on, or am I making that up?

@panva

panva commented Sep 30, 2026

Copy link
Copy Markdown
Member

The vfs module this shadow currently managed by @ljharb, who told me it's ok.

https://www.npmjs.com/package/vfs

Something doesn't add up here.

@JakobJingleheimer

Copy link
Copy Markdown
Member

I think we should not do this

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (ebef774) to head (8c31f00).
⚠️ Report is 277 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66414      +/-   ##
==========================================
+ Coverage   90.28%   90.37%   +0.09%     
==========================================
  Files         790      792       +2     
  Lines      271642   275682    +4040     
  Branches    51846    52854    +1008     
==========================================
+ Hits       245260   249156    +3896     
- Misses      16889    16939      +50     
- Partials     9493     9587      +94     
Files with missing lines Coverage Δ
lib/internal/bootstrap/realm.js 96.98% <ø> (-0.01%) ⬇️

... and 194 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants