test: make histogram external memory test less overfitting - #66416
Merged
Merged
Conversation
The test assumes too much about V8 GC's internal mechanisms and thresholds that is no longer true on newer V8 versions and break future V8 updates. Update it to only detect the occurence of major GC to make it more future-proof and unblock V8 updates. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
needs-ci
joyeecheung
added
the
fast-track
Contributor
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
jasnell
approved these changes
Sep 30, 2026
panva
approved these changes
Sep 30, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66416 +/- ##
==========================================
- Coverage 90.39% 90.38% -0.02%
==========================================
Files 792 792
Lines 275683 275683
Branches 52854 52857 +3
==========================================
- Hits 249216 249172 -44
- Misses 16886 16897 +11
- Partials 9581 9614 +33 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Sep 30, 2026
panva
added
the
commit-queue
Collaborator
|
Landed in d7ea02d |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test assumes too much about V8 GC's internal mechanisms and thresholds that is no longer true on newer V8 versions and break future V8 updates. Update it to only detect the occurence of major GC to make it more future-proof and unblock V8 updates.
Refs: #65161
Refs: #66099 (comment)
cc @jasnell