benchmark,tools: fix napi benchmarks on GHA - #66423
Draft
nigrosimone wants to merge 1 commit into
Draft
nigrosimone wants to merge 1 commit into
nigrosimone wants to merge 1 commit into
Conversation
The GHA benchmark never built the addons of benchmark/napi, and its --debug-node build made benchmark/common.js look for them in build/Debug. Build them when the napi category runs, and pick the build type as test/common does. Refs: nodejs#66395 Signed-off-by: Nigro Simone <nigro.simone@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GHA benchmark cannot run any
napi/*benchmark: every run prints "Binding failed to load" (for example on #66395). Two reasons:--debug-node(the default ofshell.nix), soprocess.features.debugis true andbenchmark/common.jslooks for the addon inbuild/Debug, while node-gyp builds it inbuild/ReleaseNow the workflow runs
make bench-addons-buildwhen the category hasnapi, andbenchmark/common.jstakes the build type fromprocess.config, astest/commondoes.Tested on my fork,
napi/make_callbackwith the same code on both sides (x86_64-linux only): https://github.com/nigrosimone/node/actions/runs/36763821317Disclosure: I used Opus 5.5 (Max) as coding assistant