Revert "deps,lib,tools: remove jitless and lite modes" by joyeecheung · Pull Request #66516 · nodejs/node

joyeecheung · 2026-10-04T22:38:31Z

Newer version of V8 no longer supports
--allow-overwriting-for-next-flag and there's no way to override the preset flag now. Revert the commit to allow users to opt-in into the flags if still necessary.

This reverts commit 7e39b87.

Newer version of V8 no longer supports --allow-overwriting-for-next-flag and there's no way to override the preset flag now. Revert the commit to allow users to opt-in into the flags if still necessary. This reverts commit 7e39b87. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot · 2026-10-04T22:38:37Z

github-actions · 2026-10-04T23:07:18Z

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot · 2026-10-04T23:11:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78173/

nodejs-github-bot · 2026-10-05T05:14:32Z

Commit Queue failed

   ✖  GitHub CI is still running
   ✖  Last Jenkins CI still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

�[36m⠋�[39m Loading data for nodejs/node/pull/66516
�[36m⠋�[39m Loading data for nodejs/node/pull/66516
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66516
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66516
�[36m⠋�[39m Getting comments from nodejs/node/pull/66516
�[36m⠋�[39m Getting commits from nodejs/node/pull/66516
✔  Done loading data for nodejs/node/pull/66516
----------------------------------- PR info ------------------------------------
Title      Revert "deps,lib,tools: remove jitless and lite modes" (#66516)
Author     Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung)
Branch     joyeecheung:allow-jitless -> nodejs:main
Labels     lib / src, fast-track, author ready, needs-ci, commit-queue, commit-queue-squash, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v26.x
Commits    1
 - Revert "deps,lib,tools: remove jitless and lite modes"
Committers 1
 - Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66516
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66516
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 04 Oct 2026 22:38:31 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/66516#pullrequestreview-5408669020
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/66516#pullrequestreview-5409344790
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-10-04T23:11:37Z: https://ci.nodejs.org/job/node-test-pull-request/78173/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78173/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78173/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78173/
✔  Build data downloaded
   ✖  Last Jenkins CI still running
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

ShogunPanda · 2026-10-05T05:44:18Z

I'm exploring an easy follow up that might fix this, following #1 on #66459 (comment).

Please hold off a little bit on this so we can evaluate.

MikeMcC399 · 2026-10-05T06:03:18Z

If this is landed, then the original PR #66459 also needs dont-land-on-v?.x labels

https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#reverting-commits

Apply dont-land-on-v?.x labels to the revert pull request and to its corresponding original pull request, unless the original pull request has already been backported.

ShogunPanda · 2026-10-05T06:29:50Z

@joyeecheung I just sent #66524, which should eliminate the need for the revert. PTAL.

aduh95 · 2026-10-05T11:06:49Z

This has green CI and approvals, #66524 has neither. Let's land this one, it's easy enough to re-apply

nodejs-github-bot · 2026-10-05T11:25:09Z

Landed in 88ec314

ShogunPanda · 2026-10-05T11:41:20Z

@aduh95 I don't understand. I explicitly blocked this. There was no rush to land, especially since I also provided a remediation in a separate PR.
Why did you merge this?

aduh95 · 2026-10-05T12:13:21Z

There was no rush to land

Yes there was, CI was broken on main

ShogunPanda · 2026-10-05T12:57:09Z

No there wasn't. I had another PR that could have been fast-tracked as well and provide a remediation.

joyeecheung · 2026-10-05T13:01:25Z

Technically it was the V8 canary broken on main, which was why I pushed the revert to canary-base to fix it for the canary CI (though it in turn needs nodejs/node-core-utils#1213 first to actually be able to build and show the failure caused by the change).

IMO when something breaks on main and noticed very quickly, the best course of action is to revert and then think about relanding. It simply means the initial patch wasn't reviewed more thoroughly and we've missed something to consider, and it's fine to take a bit more time to polish and reland, V8 does that constantly. But it's not a good state to leave a branch broken while that polishing is happening.

ShogunPanda · 2026-10-05T13:27:08Z

I kinda disagree: revert is surely viable especially when there was not ETA on a fix.
This was not the case. Canary does not have the urgence of a fast-track revert.
But on this I agree we have different (and legit) visions so I'm not arguing on this.

But, the biggest issue is that my remediation fix and my block were totally ignored.
This is definitely not cool.

aduh95 · 2026-10-05T14:01:14Z

I was not under the impression that were blocking this, FWIW here's what our collaborator guide says:

node/doc/contributing/collaborator-guide.md

Lines 200 to 202 in bbd566d

    
           Collaborators can object to a pull request by using the "Request 
        
           Changes" GitHub feature. Dissent comments alone don't constitute an 
        
           objection, nor do dissenting comments made in any associated issue.

In any case, I'm sorry that you felt you were ignored. As mentioned in #66516 (comment), it didn't look like that your PR would be ready for a while, and the list of PRs with failing CI was growing so I took the executive decision to not delay further and land this one instead.

As Joyee mentioned, you don't have to abandon #66524 – you'd need to revert the revert commit.

ShogunPanda · 2026-10-05T14:05:20Z

Even without a formal objection via request changes (which I forgot) there was also the blocked label (which might not be formally correct, but it is still there).
Anyway, no hard feelings.

trivikr · 2026-10-05T15:24:11Z

I added blocked label after Paolo commented to hold off.
I agree that "Request changes" would have been clearer, and we can follow that in future.

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 4, 2026

joyeecheung mentioned this pull request Oct 4, 2026

deps,lib,tools: remove jitless and lite modes #66459

Merged

aduh95 approved these changes Oct 4, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 4, 2026

bjohansebas approved these changes Oct 4, 2026

View reviewed changes

trivikr approved these changes Oct 5, 2026

View reviewed changes

ShogunPanda added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 5, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 5, 2026

trivikr added the blocked PRs that are blocked by other issues or PRs. label Oct 5, 2026

ShogunPanda mentioned this pull request Oct 5, 2026

src: do not use --allow-overwriting-for-next-flag #66524

Closed

RafaelGSS approved these changes Oct 5, 2026

View reviewed changes

aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Oct 5, 2026

aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 5, 2026

nodejs-github-bot merged commit 88ec314 into nodejs:main Oct 5, 2026
119 of 123 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2026

Uh oh!

Conversation

joyeecheung commented Oct 4, 2026

Uh oh!

nodejs-github-bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

nodejs-github-bot commented Oct 4, 2026

Uh oh!

nodejs-github-bot commented Oct 5, 2026

Commit Queue failed

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

MikeMcC399 commented Oct 5, 2026

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

aduh95 commented Oct 5, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 5, 2026

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

aduh95 commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

joyeecheung commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

aduh95 commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShogunPanda commented Oct 5, 2026

Uh oh!

trivikr commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

aduh95 commented Oct 5, 2026 •

edited

Loading

joyeecheung commented Oct 5, 2026 •

edited

Loading

aduh95 commented Oct 5, 2026 •

edited

Loading