Conversation
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9205 +/- ##
==========================================
- Coverage 86.07% 86.05% -0.02%
==========================================
Files 86 86
Lines 6060 6060
Branches 359 359
==========================================
- Hits 5216 5215 -1
- Misses 840 841 +1
Partials 4 4 ☔ View full report in Codecov by Harness. |
MattIPv4
approved these changes
Oct 5, 2026
MattIPv4
left a comment
Member
There was a problem hiding this comment.
Needs a changeset add --empty, but otherwise 🙌 love to see some a11y love.
Contributor
📦 Build Size ComparisonSummary
|
… changeset Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Storybook's accessibility addon (
@storybook/addon-a11y) to theui-componentsStorybook, so every Story gets checked by axe-core against WCAG rules and the results show up in the new Accessibility panel..storybook/main.tsparameters.a11y.testto'todo'in.storybook/preview.tsx, so violations surface as warnings instead of failures while we work through the existing onesI didn't wire it into CI here. Since we're on the webpack builder, the Vitest addon path isn't available to us, so enforcement would come either from Chromatic's accessibility tests (a project setting, no repo change) or from
@storybook/test-runner. Happy to do either as a follow-up, and to fliptestto'error'once the current violations are fixed.The extra churn in
pnpm-lock.yamlis pnpm pruning stale entries (e.g.eslint-plugin-import) once the importer changed.Validation
Run
pnpm storybookinpackages/ui-componentsand open the Accessibility tab on any Story.storybook:build,tsc, ESLint and the unit tests all pass locally.Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.