Skip to content

feat(ui-components): add accessibility testing to storybook - #9205

Open
ovflowd wants to merge 2 commits into
mainfrom
feat/storybook-a11y
Open

ovflowd wants to merge 2 commits into
mainfrom
feat/storybook-a11y

Conversation

@ovflowd

@ovflowd ovflowd commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Description

This PR adds Storybook's accessibility addon (@storybook/addon-a11y) to the ui-components Storybook, so every Story gets checked by axe-core against WCAG rules and the results show up in the new Accessibility panel.

  • Registered the addon in .storybook/main.ts
  • Set parameters.a11y.test to 'todo' in .storybook/preview.tsx, so violations surface as warnings instead of failures while we work through the existing ones

I didn't wire it into CI here. Since we're on the webpack builder, the Vitest addon path isn't available to us, so enforcement would come either from Chromatic's accessibility tests (a project setting, no repo change) or from @storybook/test-runner. Happy to do either as a follow-up, and to flip test to 'error' once the current violations are fixed.

The extra churn in pnpm-lock.yaml is pnpm pruning stale entries (e.g. eslint-plugin-import) once the importer changed.

Validation

Run pnpm storybook in packages/ui-components and open the Accessibility tab on any Story. storybook:build, tsc, ESLint and the unit tests all pass locally.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 18:26
@ovflowd
ovflowd requested review from a team as code owners October 5, 2026 18:26
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Oct 5, 2026 8:42pm UTC

Request Review

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.05%. Comparing base (e7bbce7) to head (960e8b2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9205      +/-   ##
==========================================
- Coverage   86.07%   86.05%   -0.02%     
==========================================
  Files          86       86              
  Lines        6060     6060              
  Branches      359      359              
==========================================
- Hits         5216     5215       -1     
- Misses        840      841       +1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset add --empty, but otherwise 🙌 love to see some a11y love.

This comment was marked as low quality.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.15 MB
New Total First Load JS 7.15 MB
Delta 0 B (0.00%)

… changeset

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview — 960e8b20 Deployed Oct 5, 2026 by vercel[bot]
Storybook — 960e8b20 Deployed Oct 5, 2026 by ovflowd via Chromatic #2289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants