Skip to content

nekojanai:chore(file-access-mode-constants-follow-up): DRY up code #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AugustinMauroy merged 1 commit into from
Sep 10, 2025
Merged

nekojanai:chore(file-access-mode-constants-follow-up): DRY up code #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions recipes/fs-access-mode-constants/src/workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { getNodeImportStatements } from '@nodejs/codemod-utils/ast-grep/import-s
export default function tranform(root: SgRoot<Js>): string | null {
const rootNode = root.root();
const edits: Edit[] = [];
const patterns = ['F_OK', 'R_OK', 'W_OK', 'X_OK'];

// @ts-expect-error - ast-grep types are not fully compatible with JSSG types
const requireStatements = getNodeRequireCalls(root, 'fs');
Expand All @@ -22,7 +23,7 @@ export default function tranform(root: SgRoot<Js>): string | null {
})
.map((v) => v.text());
objPatArr = objPatArr.filter(
(v) => !['F_OK', 'R_OK', 'W_OK', 'X_OK'].includes(v),
(v) => !patterns.includes(v),
);
objPatArr.push('constants');
edits.push(objectPattern.replace(`{ ${objPatArr.join(', ')} }`));
Expand All @@ -45,7 +46,7 @@ export default function tranform(root: SgRoot<Js>): string | null {
})
.map((v) => v.text());
objPatArr = objPatArr.filter(
(v) => !['F_OK', 'R_OK', 'W_OK', 'X_OK'].includes(v),
(v) => !patterns.includes(v),
);
const promisesImport = objPatArr.find((v) => v.startsWith('promises'));
if (promisesImport) {
Expand All @@ -65,15 +66,13 @@ export default function tranform(root: SgRoot<Js>): string | null {
}
}

for (const _OK of ['F_OK', 'R_OK', 'W_OK', 'X_OK']) {
for (const _OK of patterns) {
for (const [prefix, replacement] of [
['fs.', 'fs.constants.'],
['', `${promisesImportName ? promisesImportName : ''}constants.`],
]) {
const patterns = rootNode.findAll({
rule: {
pattern: `${prefix}${_OK}`,
},
rule: { pattern: `${prefix}${_OK}` },
});
for (const pattern of patterns) {
edits.push(pattern.replace(`${replacement}${_OK}`));
Expand Down
Loading