Repository navigation
feat(migrate-legacy-buffer-atob-btoa): introduce - #206
Merged
JakobJingleheimer merged 10 commits intoOct 15, 2025
Merged
JakobJingleheimer merged 10 commits into
JakobJingleheimer merged 10 commits into
Conversation
brunocroh
reviewed
Sep 10, 2025
AugustinMauroy
left a comment
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
Noice! But my advice is to start writing test commit them on local then build the codemod and then push everything
nekojanai
force-pushed
the
feat(`migrate-legacy-buffer-atob-btoa`)
branch
from
September 17, 2025 16:34
23a2fcf to
2c2fee2
Compare
nekojanai
force-pushed
the
feat(`migrate-legacy-buffer-atob-btoa`)
branch
from
September 17, 2025 16:37
2c2fee2 to
f6f823e
Compare
nekojanai
marked this pull request as ready for review
September 17, 2025 16:38
AugustinMauroy
left a comment
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
Missing test/feature:
- dynamic import
- esm import
Contributor
Author
|
@AugustinMauroy Could you provide examples for dynamic and esm imports to test against? |
Member
ESM importInput/before: import buffer from "node:buffer";
// do stuffDynamic importconst buffer = await import("node:buffer");
// do stuffDon't worry it's shouldn't complicated because we have serval utilities for that |
JakobJingleheimer
added
the
awaiting author
brunocroh
reviewed
Sep 28, 2025
Contributor
Author
|
Should be gtm |
brunocroh
removed
the
awaiting author
brunocroh
approved these changes
Sep 30, 2025
brunocroh
left a comment
brunocroh
left a comment
Member
There was a problem hiding this comment.
Looks great now, Thank you!
AugustinMauroy
added
the
awaiting author
avivkeller
reviewed
Oct 10, 2025
avivkeller
approved these changes
Oct 10, 2025
Contributor
Author
|
@AugustinMauroy should be gtm now |
AugustinMauroy
approved these changes
Oct 13, 2025
AugustinMauroy
added
awaiting reviewer
JakobJingleheimer
approved these changes
Oct 14, 2025
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
Member
There was a problem hiding this comment.
Awesome, thanks for another one @nekojanai 🙌
JakobJingleheimer
removed
the
awaiting reviewer
JakobJingleheimer
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #98