Skip to content

fix(codemod-utils): handle non-node imports correctly - #505

Merged
AugustinMauroy merged 8 commits into
mainfrom
fix-alex-issues
Jul 19, 2026
Merged

AugustinMauroy merged 8 commits into
mainfrom
fix-alex-issues

Conversation

@AugustinMauroy

Copy link
Copy Markdown
Member

No description provided.

cause: .slip on undefined dued to catching imported type
cause: import-statement was catching `vitest` dude to `vite`
@AugustinMauroy
AugustinMauroy requested a review from a team July 13, 2026 21:08
@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Jul 13, 2026
@AugustinMauroy AugustinMauroy changed the title fix(cal-com): Issue raised by Alex fix(codemod utils): handle non-node imports correctly Jul 14, 2026

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we should have some tests with the node: prefix and without it.

There are some seemingly unrelated tests added here. Are they actually related? If not, they should go in their own PR.

Comment thread utils/src/ast-grep/import-statement.test.ts Outdated
@AugustinMauroy

Copy link
Copy Markdown
Member Author

There are some seemingly unrelated tests added here. Are they actually related? If not, they should go in their own PR.

that was to fetch ast and search for type node but it's an unnamed node ...

@AugustinMauroy AugustinMauroy changed the title fix(codemod utils): handle non-node imports correctly fix(codemod-utils): handle non-node imports correctly Jul 19, 2026
@AugustinMauroy
AugustinMauroy requested a review from a team July 19, 2026 18:09
@AugustinMauroy
AugustinMauroy requested a review from a team July 19, 2026 18:26
@AugustinMauroy
AugustinMauroy merged commit 7af7cdc into main Jul 19, 2026
6 checks passed
@AugustinMauroy
AugustinMauroy deleted the fix-alex-issues branch July 19, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewer Author has responded and needs action from the reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants