Repository navigation
Nominate @avivkeller to @nodejs/web-infra #54
Description
This is a clean continuation of #6 and nodejs/nodejs.org#7208
Aviv has continued to show up across our web presence, which the above issues go into great detail to enumerate. He will provide a vital source of continuity and security acumen to the web team.
Perhaps more importantly, Aviv recently joined the team at JSConf, received a JavaScriptLandia Award for Outstanding Contribution from a New Arrival, and co-led a collaboration session at the collaborator summit.
Contribution Overview (from the previous issue)
| Repository | PRs | Issues |
|---|---|---|
| Node.js Organization | Authored · Commented | Authored · Commented |
nodejs/nodejs.org |
Authored · Commented | Authored · Commented |
nodejs/doc-kit |
Authored · Commented | Authored · Commented |
nodejs/node |
Authored · Commented | Authored · Commented |
nodejs/help |
Authored · Commented | Authored · Commented |
(Edit by @avivkeller: api-docs-tooling -> doc-kit)
Activity
ovflowd commentedon Oct 19, 2025
I finally can publicly say, I'm a strong +1
bmuenzenmeyer commentedon Oct 19, 2025
Note
Tangent: As Aviv himself mentioned earlier, the current governance says nomination can only come from the TSC or build teams, which I think should be amended. As far as I know, my only nomination came as a result of nodejs/nodejs.org#5465
flakey5 commentedon Oct 19, 2025
+1
(also +1 to what @bmuenzenmeyer said re amending who can nominate web-infra members, ideally anyone on the team could nominate others but at the very least web admins should be able to do it)
flakey5 commentedon Oct 19, 2025
The web infra team is still bound to follow the Collaborator Guidelines of the Build WG, which has a clause stating any nominee that's not a Node.js Collaborator needs to get @nodejs/tsc approval as well (nodejs/build#3956):
I believe this applies here afaict?
MattIPv4 commentedon Oct 21, 2025
While I am in principle a +1 here, given the level of access web-infra has and the general high-trust nature of the team, perhaps it'd be useful here to include a justification for why Aviv (and generally for the process in future, anyone being nominated) needs to be added to the team, beyond just "because they should be due to their activity", if that makes sense? What additional access will they benefit from in their work on the project, what gap does the team have today that Aviv (or any other nominee) will fill?
bmuenzenmeyer commentedon Oct 22, 2025
Why? Because Aviv has demonstrated sustained contributions in the scope of the web-infra team.
From the build WG document
From the existing document
Let's break it down one by one (this is just authored PRs):
basejob nodejs.org#7624ui-componentschanges nodejs.org#7785node:testnodejs.org#7623 - standardsI'm gonna stop there. That's just the website. Most of doc-kits workflows were authored by him too.
jasnell commentedon Oct 22, 2025
With my TSC hat on, definite +1
ShogunPanda commentedon Oct 22, 2025
+1
ovflowd commentedon Oct 22, 2025
@bmuenzenmeyer I think what @MattIPv4 meant is: Should we just keep adding people on Web Infra due to accomplishments or because we need more people with snesitive access to help us with sensitive work?
I think the nature of Web Infra, it's a good questioning of wether people really need to be part of this team. It's not a glamorous team, it's one that pretty much comes with on-call work, handling incidents and postmortems and what not. In @avivkeller case the have absolutely shown interest and have been contributing with our Infra, but that said I agree with @MattIPv4 that nominating to this team isn't a step up from website team, and that we should be careful with the amount of people that are part of the team :D
mcollina commentedon Oct 22, 2025
@ovflowd to make a example on this: I don't have access to our infra (in any form), nor I can sign releases.
avivkeller commentedon Nov 3, 2025
No objections in last week's TSC meeting. @mcollina should we remove this from the tsc-agenda ?
If this is approved, we can begin the onboarding process per #17
ovflowd commentedon Nov 3, 2025
Sounds good to me. @mcollina can you confirm? I can take care of the onboarding. @nodejs/web-infra anyone -1 or +1 here? (On Aviv's nomination)
mcollina commentedon Nov 3, 2025
Confirmed
MattIPv4 commentedon Nov 3, 2025
👍 I'm okay with it.
I do think it'd be good to understand what additional access @avivkeller believes will be useful here / what new skills will be added to web-infra that we currently lack? A focus on security perhaps?
A lot of the discussion so far seems to be focused on Aviv's contributions thus far, and while I do not dispute those are great, I'm not sure joining web-infra is a merit-based "promotion" really, rather a wholly separate set of critical responsibilities.
avivkeller commentedon Nov 5, 2025
I think it'd be nice for me to, in the context of what I've been working on (doc-kit, etc):
Also, being pinged for @nodejs/web-infra related changes in nodejs/node will help me be "in the know" of some of those related issues.
But, also, as you mentioned, I'm happy to provide security assistance in the ways I know best
bmuenzenmeyer commentedon Nov 6, 2025
I've lost count of the number of times I have had to log into vercel to give him feedback on a build log - so this is a tangible tangible improvement.
My list of contributions was not simply to illustrate commitment or mere activity; each of those PRs aligns with the mission of the web-infra team (more so than the website). This nomination brings Aviv's skillset in alignment with his output