Fix Ring/BoundedQueue not using the pin values(alignment/size) given while type name is generic#50
Open
caner-milko wants to merge 2 commits intonodos-1.3from
Open
Fix Ring/BoundedQueue not using the pin values(alignment/size) given while type name is generic#50caner-milko wants to merge 2 commits intonodos-1.3from
caner-milko wants to merge 2 commits intonodos-1.3from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Ring/BoundedQueue to properly use pin values (alignment/size) provided at creation time and during generic type resolution. Previously, the Ring was always created with a hardcoded size of 1, ignoring the configured values.
Key changes:
- Ring initialization now reads and applies Input, Alignment, and Size pin values before creating the Ring object
- Pin value watchers now include null checks for Ring before accessing it
- RepeatWhenFilling watcher now triggers path restart when the value changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fcturan20
approved these changes
Jan 9, 2026
…on creation/while generic
caner-milko
force-pushed
the
fix-ring-size-on-creation
branch
from
86e9a55 to
91194f1
Compare
caner-milko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.