Display posture reminders using native notifications#1
Open
pelf wants to merge 6 commits intonoeltock:masterfrom
Open
Display posture reminders using native notifications#1pelf wants to merge 6 commits intonoeltock:masterfrom
pelf wants to merge 6 commits intonoeltock:masterfrom
Conversation
And tweak documentation
This adds a couple of checkboxes to the UI to allow the users to control how they want to be reminded of their posture: voice and/or notification.
Slightly arbitrary version update. Semantic versioning is always a bit ambiguous for standalone apps, but given the introduction of a new feature, new settings, UI changes and a change to the format of the stored settings, one could argue 2.0 is what makes sense. Happy to change it to something that makes more sense.
|
Can this be merged? I think it would be super useful. |
Author
|
@PfisterFactor 🤷♂️ That's up to @noeltock Feel free to use my fork directly, which is what I do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Voice reminders did not work for me personally. My laptop could be muted, or my headphones off, or sometimes it would just be noisy at inconvenient times. I'd rather be reminded via OS notifications.
That being said, I can see how the opposite may be true for other people, so I've added a settings section which allows users to select how they want to be reminded.
I understand that, given the minimalistic approach of this app, this might not be something you want added to your app. It's obviously up to you if you want to merge this change or not. I won't take it personally 😉
The checkboxes are not particularly pretty 🤷♂️ Maybe I should add some styling to make them a bit more muted?
Changes
1️⃣ It uses the native OS notification system to remind users of their posture. It displays a random message portraying the benefits of a good posture.
2️⃣ It adds two checkboxes to the settings section, allowing users to choose how they want to be reminded: voice and/or notification.
3️⃣ It upgrades electron to version 3.