Skip to content

Option to configure callback URL host for a provider#34

Merged
nogginbox merged 2 commits into
developfrom
feature/set-url
Apr 12, 2026
Merged

Option to configure callback URL host for a provider#34
nogginbox merged 2 commits into
developfrom
feature/set-url

Conversation

@nogginbox

Copy link
Copy Markdown
Owner
  • Configurable callback URL host: Added CallbackUrlHost option to ProviderConfig so the host/port used in OAuth callback URLs can be explicitly set. Useful when running behind a reverse proxy (e.g. YARP, NGINX) where auto-detection doesn't work.
  • ILogger per provider: Each provider now receives a typed ILogger<T> (e.g. ILogger<GitHubProvider>) via ILoggerFactory in the ProviderFactory, so providers can log with proper category names.
  • Nullability cleanup: Tightened nullability annotations on AuthConfigSection, ProviderConfig, and JsonSerializerExtensions.

Test plan

  • All 21 existing tests pass
  • Verify callback URL host override works end-to-end behind a reverse proxy
  • Confirm logging output appears with expected category names

@nogginbox nogginbox self-assigned this Apr 12, 2026
@nogginbox nogginbox merged commit f0150e9 into develop Apr 12, 2026
3 checks passed
@nogginbox nogginbox deleted the feature/set-url branch April 12, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant