fix a bug : when sklearn has string characters in its version, sklear…#68
Open
earlsuke wants to merge 1 commit into
Open
fix a bug : when sklearn has string characters in its version, sklear…#68earlsuke wants to merge 1 commit into
earlsuke wants to merge 1 commit into
Conversation
…n-porter raises a value error
SoftwareApe
reviewed
Apr 22, 2020
|
|
||
| ## Suffix lists for minor, patch version in sklearn | ||
| MINOR_VERSION_SUFFIX_LIST = ["rc3", "rc2", "rc1", "b1", "a1"] | ||
| PATCH_VERSION_SUFFIX_LIST = ["post1", "0b1", "0b2"] |
There was a problem hiding this comment.
At least post1 is not part of the patch version, but after the patch version:
SoftwareApe
reviewed
Apr 22, 2020
Comment on lines
+60
to
+93
|
|
||
| ## Suffix lists for minor, patch version in sklearn | ||
| MINOR_VERSION_SUFFIX_LIST = ["rc3", "rc2", "rc1", "b1", "a1"] | ||
| PATCH_VERSION_SUFFIX_LIST = ["post1", "0b1", "0b2"] | ||
|
|
||
| sklearn_ver = str(sklearn_ver).split('.') | ||
| sklearn_ver = [int(v) for v in sklearn_ver] | ||
| major, minor = sklearn_ver[0], sklearn_ver[1] | ||
| patch = sklearn_ver[2] if len(sklearn_ver) >= 3 else 0 | ||
|
|
||
| major_cand_str = sklearn_ver[0] | ||
| minor_cand_str = sklearn_ver[1] | ||
| patch_cand_str = sklearn_ver[2] if len(sklearn_ver) >= 3 else '0' | ||
|
|
||
| ## Convert version str to integer | ||
| major = int(major_cand_str) | ||
|
|
||
| try: | ||
| minor = int(minor_cand_str) | ||
|
|
||
| except ValueError as ve: | ||
| for check_key in MINOR_VERSION_SUFFIX_LIST: | ||
| if check_key in minor_cand_str: | ||
| minor_cand_str.replace(check_key, '') | ||
| break | ||
| minor = int(minor_cand_str) | ||
|
|
||
| try: | ||
| patch = int(patch_cand_str) | ||
|
|
||
| except ValueError as ve: | ||
| for check_key in PATCH_VERSION_SUFFIX_LIST: | ||
| if check_key in patch_cand_str: | ||
| patch_cand_str.replace(check_key, '0') | ||
| break | ||
| patch = int(patch_cand_str) | ||
|
|
There was a problem hiding this comment.
This seems like a perfect application for regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n-porter raises a value error
#67