fix(a11y): label filter rows as radiogroups with visible prefix and aria-checked#14
Merged
Merged
Conversation
…ria-checked Type and status filter rows on the browse page used plain <button> elements with no visible label, making them ambiguous and inaccessible. Screen readers announced options as generic buttons with no selection state. - Wrap each filter row in role="radiogroup" with aria-label="Type"/"Status" - Add role="radio" + aria-checked to each option button - Add visible "Type" / "Status" label span as first child of each row - Update tests to query by radiogroup/radio role instead of aria-label hack Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #13 addressing review feedback on the filter row UX and accessibility.
Changes:
role="radiogroup"witharia-label="Type"/aria-label="Status"role="radio"+aria-checkedto each option buttonradiogroup/radiorole (cleaner than thearia-labelhack added previously)Test plan
bash scripts/check.shpasses (7/7)🤖 Generated with Claude Code